Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does "exist in the present context" mean? #1138

Open
TomHennen opened this issue Sep 19, 2024 · 2 comments
Open

What does "exist in the present context" mean? #1138

TomHennen opened this issue Sep 19, 2024 · 2 comments

Comments

@TomHennen
Copy link
Contributor

What does "exist in the present context" mean?

Originally posted by @marcelamelara in #1094 (comment)

@zachariahcox

for git repos, a revision is just a tree id in a big database.
Preventing trees from existing can only happen at push receive time and causes a ton of developer friction.

Especially when teams rely on pull requests, the "reachable from this ref" security boundary is the most practical. It models whether a commit / tree id is included in a specific subset. That subset has certain properties. I think that's what we're saying by context here, but it might need some additional definition here!

@zachariahcox
Copy link
Collaborator

zachariahcox commented Sep 19, 2024

I think we're proposing a new definition:

"Revision context": a named subset of all revisions in the database. Inclusion in the subset can be governed by policy.

@TomHennen
Copy link
Contributor Author

To be honest, a lot of that went over my head. :p

I was going to suggest just removing "in its present context", but I think what you're after is protecting the association of refs with the revision. That makes me think this is related to the source_branches field in the VSA.

So maybe "A source attestation contains information about how a specific revision was created and how it came to have any branches, tags, or other refs associated with it."

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Status: No status
Development

No branches or pull requests

2 participants