Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit code review? #1140

Open
TomHennen opened this issue Sep 19, 2024 · 2 comments · May be fixed by #1144
Open

Be more explicit code review? #1140

TomHennen opened this issue Sep 19, 2024 · 2 comments · May be fixed by #1144
Assignees

Comments

@TomHennen
Copy link
Contributor

This requirement isn't very clear. Is this alluding to code review?

Originally posted by @marcelamelara in #1094 (comment)

@TomHennen
Copy link
Contributor Author

FYI @zachariahcox

FWIW I think requiring code review at Level 3 wasn't the intent? We'd talked about having a separate tag that indicates if revisions are subject to code review.

@zachariahcox
Copy link
Collaborator

the text at the time was: "The change management tool MUST be able to authoritatively state that each new revision reachable from the protected branch represents only the changes reviewed via the process."

I think we can fix this by sticking with the "change management" phrase everywhere.
EG:

"changes reviewed" -> "changes managed"

@TomHennen TomHennen self-assigned this Sep 20, 2024
@TomHennen TomHennen linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants