Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis fixes #1255

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Static analysis fixes #1255

merged 8 commits into from
Aug 5, 2024

Conversation

RayXpub
Copy link
Collaborator

@RayXpub RayXpub commented Aug 4, 2024 •
edited
Loading

Motivation

This PR applies several fixes from static analysis findings.

Solution

Fixes include:

  • Unused state variables removal
  • Unused imports removal
  • Unused events removal
  • Unused custom errors removal
  • Add of missing zero address check
  • Implementation of missing getter
  • Use of constants instead of magic numbers

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 4, 2024 •
edited
Loading

LCOV of commit 2bf975e during Solidity Foundry #6979

Summary coverage rate:
  lines......: 98.7% (1831 of 1855 lines)
  functions..: 96.3% (342 of 355 functions)
  branches...: 90.6% (774 of 854 branches)

Files changed coverage rate: n/a

@RayXpub RayXpub marked this pull request as ready for review August 5, 2024 12:34
@RayXpub RayXpub requested review from makramkd, elatoskinas and a team as code owners August 5, 2024 12:34
@makramkd
Copy link
Contributor

makramkd commented Aug 5, 2024

🐍

@RayXpub RayXpub enabled auto-merge (squash) August 5, 2024 14:49
@RayXpub RayXpub merged commit 49cfead into ccip-develop Aug 5, 2024
102 checks passed
@RayXpub RayXpub deleted the chore/static-analysis-fixes branch August 5, 2024 15:02
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

dhaidashenko pushed a commit that referenced this pull request Sep 2, 2024
@RayXpub @asoliman92
Static analysis fixes (#1255)
b1694e2 
## Motivation

This PR applies several fixes from static analysis findings.

## Solution

Fixes include:

- Unused state variables removal
- Unused imports removal
- Unused events removal
- Unused custom errors removal
- Add of missing zero address check
- Implementation of missing getter
- Use of constants instead of magic numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@RensR RensR RensR approved these changes

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RayXpub @makramkd @RensR