From 6815f5f6749bb4230f070eda2cb1ba4118186b7b Mon Sep 17 00:00:00 2001 From: Augustus Chang Date: Thu, 16 May 2024 16:52:54 -0400 Subject: [PATCH] simplify comment --- median/plugin.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/median/plugin.go b/median/plugin.go index cbff349..54cef7f 100644 --- a/median/plugin.go +++ b/median/plugin.go @@ -31,10 +31,9 @@ func (p *Plugin) NewMedianFactory(ctx context.Context, provider types.MedianProv ctxVals.SetValues(ctx) lggr := logger.With(p.Logger, ctxVals.Args()...) - // Setting includeGasPriceSubunitsInObservation properly ensures we do not break libocr codec - // by including gasPriceSubunits in the observation when not allowed - // Once all chainlink nodes in DONs have libocr version >= fd3cab206b2c - // this check and IncludeGasPriceSubunitsInObservation field can be removed + // We may omit gas price in observation to maintain backwards compability in libocr (with older nodes). + // Once all chainlink nodes have updated to libocr version >= fd3cab206b2c + // the IncludeGasPriceSubunitsInObservation field can be removed _, isZeroDataSource := gasPriceSubunits.(*ZeroDataSource)