Skip to content

Commit

Permalink
[chore] Small fixes (#15230)
Browse files Browse the repository at this point in the history
* [chore] Small fixes

- Ensure we start the handler
- Ensure fetch message ID is < 128

* Fix tests
  • Loading branch information
cedric-cordenier authored Nov 15, 2024
1 parent 1a80fec commit 93ee177
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion core/capabilities/compute/compute.go
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ func (c *Compute) createFetcher() func(ctx context.Context, req *wasmpb.FetchReq
)

messageID := strings.Join([]string{
req.Metadata.WorkflowId,
req.Metadata.WorkflowExecutionId,
ghcapabilities.MethodComputeAction,
c.idGenerator(),
Expand Down
1 change: 0 additions & 1 deletion core/capabilities/compute/compute_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ func TestComputeFetch(t *testing.T) {
th.connector.EXPECT().GatewayIDs().Return([]string{"gateway1", "gateway2"})

msgID := strings.Join([]string{
workflowID,
workflowExecutionID,
ghcapabilities.MethodComputeAction,
validRequestUUID,
Expand Down
2 changes: 1 addition & 1 deletion core/services/standardcapabilities/delegate.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ func (d *Delegate) ServicesForSpec(ctx context.Context, spec job.Job) ([]job.Ser
}

computeSrvc := compute.NewAction(cfg, log, d.registry, handler, idGeneratorFn)
return []job.ServiceCtx{computeSrvc}, nil
return []job.ServiceCtx{handler, computeSrvc}, nil
}

standardCapability := newStandardCapabilities(log, spec.StandardCapabilitiesSpec, d.cfg, telemetryService, kvStore, d.registry, errorLog,
Expand Down

0 comments on commit 93ee177

Please sign in to comment.