Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alter default sort to ASC #15411

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

EasterTheBunny
Copy link
Contributor

Changed LogPoller DSL default sort to match existing default sorting.

@EasterTheBunny EasterTheBunny requested review from a team as code owners November 25, 2024 21:52
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

AER Report: CI Core

aer_workflow , commit , Scheduled Run Frequency , Clean Go Tidy & Generate , Detect Changes , Flakeguard Root Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Flakeguard Deployment Project , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Test failure in github.com/smartcontractkit/chainlink/v2/core/services/relay/evm package: go_core_tests

Source of Error:
Run tests	2024-12-04T18:48:56.3350810Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/types/interfacetests/utils.go:62 +0x30
Run tests	2024-12-04T18:48:56.3351096Z testing.tRunner(0xc00434f520, 0xc001c4a0c0)
Run tests	2024-12-04T18:48:56.3351359Z 	/opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1690 +0xf4
Run tests	2024-12-04T18:48:56.3351544Z created by testing.(*T).Run in goroutine 946710
Run tests	2024-12-04T18:48:56.3351917Z 	/opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1743 +0x390
Run tests	2024-12-04T18:48:56.3351925Z 
Run tests	2024-12-04T18:48:56.3352071Z goroutine 862883 [select, 15 minutes]:
Run tests	2024-12-04T18:48:56.3352445Z github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel.func1()
Run tests	2024-12-04T18:48:56.3352987Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:56 +0x67
Run tests	2024-12-04T18:48:56.3353455Z created by github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel in goroutine 862882
Run tests	2024-12-04T18:48:56.3353988Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:55 +0x8f
Run tests	2024-12-04T18:48:56.3354005Z 
Run tests	2024-12-04T18:48:56.3354146Z goroutine 830843 [select, 15 minutes]:
Run tests	2024-12-04T18:48:56.3354512Z github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel.func1()
Run tests	2024-12-04T18:48:56.3355050Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:56 +0x67
Run tests	2024-12-04T18:48:56.3355513Z created by github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel in goroutine 830812
Run tests	2024-12-04T18:48:56.3356039Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:55 +0x8f
Run tests	2024-12-04T18:48:56.3356046Z 
Run tests	2024-12-04T18:48:56.3356193Z goroutine 830359 [select, 15 minutes]:
Run tests	2024-12-04T18:48:56.3356551Z github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel.func1()
Run tests	2024-12-04T18:48:56.3357079Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:56 +0x67
Run tests	2024-12-04T18:48:56.3357535Z created by github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel in goroutine 830800
Run tests	2024-12-04T18:48:56.3358065Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:55 +0x8f
Run tests	2024-12-04T18:48:56.3358076Z 
Run tests	2024-12-04T18:48:56.3358191Z goroutine 559301 [select]:
Run tests	2024-12-04T18:48:56.3358662Z github.com/smartcontractkit/chainlink-common/pkg/timeutil.(*Ticker).run(0xc0064b6738, 0xc002484bd0, 0xc004d18360)
Run tests	2024-12-04T18:48:56.3359210Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:39 +0x169
Run tests	2024-12-04T18:48:56.3359613Z created by github.com/smartcontractkit/chainlink-common/pkg/timeutil.NewTicker in goroutine 559510
Run tests	2024-12-04T18:48:56.3360161Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:19 +0x119
Run tests	2024-12-04T18:48:56.3360171Z 
Run tests	2024-12-04T18:48:56.3360282Z goroutine 812844 [select]:
Run tests	2024-12-04T18:48:56.3360752Z github.com/smartcontractkit/chainlink-common/pkg/timeutil.(*Ticker).run(0xc007094558, 0xc00007fb20, 0xc002a93320)
Run tests	2024-12-04T18:48:56.3361296Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:29 +0xb5
Run tests	2024-12-04T18:48:56.3361694Z created by github.com/smartcontractkit/chainlink-common/pkg/timeutil.NewTicker in goroutine 813266
Run tests	2024-12-04T18:48:56.3362237Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:19 +0x119
Run tests	2024-12-04T18:48:56.3362245Z 
Run tests	2024-12-04T18:48:56.3362361Z goroutine 858288 [runnable]:
Run tests	2024-12-04T18:48:56.3362828Z github.com/smartcontractkit/chainlink-common/pkg/timeutil.(*Ticker).run(0xc0061b3380, 0xc003a12bd0, 0xc00261c780)
Run tests	2024-12-04T18:48:56.3363365Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:39 +0x169
Run tests	2024-12-04T18:48:56.3363889Z created by github.com/smartcontractkit/chainlink-common/pkg/timeutil.NewTicker in goroutine 857373
Run tests	2024-12-04T18:48:56.3364538Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:19 +0x119
Run tests	2024-12-04T18:48:56.3364546Z 
Run tests	2024-12-04T18:48:56.3364661Z goroutine 236556 [runnable]:
Run tests	2024-12-04T18:48:56.3365130Z github.com/smartcontractkit/chainlink-common/pkg/timeutil.(*Ticker).run(0xc005729c50, 0xc001f2bf10, 0xc001f00660)
Run tests	2024-12-04T18:48:56.3365669Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:39 +0x169
Run tests	2024-12-04T18:48:56.3366069Z created by github.com/smartcontractkit/chainlink-common/pkg/timeutil.NewTicker in goroutine 236855
Run tests	2024-12-04T18:48:56.3366611Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:19 +0x119
Run tests	2024-12-04T18:48:56.3366622Z 
Run tests	2024-12-04T18:48:56.3366731Z goroutine 237354 [select]:
Run tests	2024-12-04T18:48:56.3367328Z github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller.(*logPoller).backgroundWorkerRun(0xc00236b080)
Run tests	2024-12-04T18:48:56.3367693Z 	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:693 +0x1d8
Run tests	2024-12-04T18:48:56.3368564Z created by github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting.(*EVMChainComponentsInterfaceTester[...]).GetContractReader.(*logPoller).Start.func1 in goroutine 237351
Run tests	2024-12-04T18:48:56.3368913Z 	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:509 +0xa9
Run tests	2024-12-04T18:48:56.3368921Z 
Run tests	2024-12-04T18:48:56.3369069Z goroutine 236903 [select, 18 minutes]:
Run tests	2024-12-04T18:48:56.3369430Z github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel.func1()
Run tests	2024-12-04T18:48:56.3369964Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:56 +0x67
Run tests	2024-12-04T18:48:56.3370427Z created by github.com/smartcontractkit/chainlink-common/pkg/services.StopRChan.CtxCancel in goroutine 236856
Run tests	2024-12-04T18:48:56.3370964Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/services/stop.go:55 +0x8f
Run tests	2024-12-04T18:48:56.3370973Z 
Run tests	2024-12-04T18:48:56.3371083Z goroutine 820880 [runnable]:
Run tests	2024-12-04T18:48:56.3371546Z github.com/smartcontractkit/chainlink-common/pkg/timeutil.(*Ticker).run(0xc008e19758, 0xc004166b60, 0xc00407e060)
Run tests	2024-12-04T18:48:56.3372095Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:39 +0x169
Run tests	2024-12-04T18:48:56.3372498Z created by github.com/smartcontractkit/chainlink-common/pkg/timeutil.NewTicker in goroutine 821203
Run tests	2024-12-04T18:48:56.3373040Z 	/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.3.1-0.20241125150608-97ceadb2072d/pkg/timeutil/ticker.go:19 +0x119
Run tests	2024-12-04T18:48:56.3373050Z 
Run tests	2024-12-04T18:48:56.3373155Z goroutine 526036 [select]:
Run tests	2024-12-04T18:48:56.3373570Z github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller.(*logPoller).run(0xc002783500)
Run tests	2024-12-04T18:48:56.3373925Z 	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:615 +0x206
Run tests	2024-12-04T18:48:56.3374795Z created by github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting.(*EVMChainComponentsInterfaceTester[...]).GetContractReader.(*logPoller).Start.func1 in goroutine 525375
Run tests	2024-12-04T18:48:56.3375135Z 	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:508 +0x6d
Run tests	2024-12-04T18:48:56.3375147Z 
Run tests	2024-12-04T18:48:56.3375250Z goroutine 885192 [select]:
Run tests	2024-12-04T18:48:56.3375742Z github.com/smartcontractkit/chainlink/v2/core/chains/evm/logpoller.(*logPoller).backgroundWorkerRun(0xc00319f680)
Run tests	2024-12-04T18:48:56.3376257Z 	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:693 +0x1d8
Run tests	2024-12-04T18:48:56.3377150Z created by github.com/smartcontractkit/chainlink/v2/core/services/relay/evm/evmtesting.(*EVMChainComponentsInterfaceTester[...]).GetContractReader.(*logPoller).Start.func1 in goroutine 885189
Run tests	2024-12-04T18:48:56.3377625Z 	/home/runner/work/chainlink/chainlink/core/chains/evm/logpoller/log_poller.go:509 +0xa9
Run tests	2024-12-04T18:48:56.3377633Z 
Run tests	2024-12-04T18:48:56.3377780Z goroutine 862632 [select, 15 minutes]:
Run tests	2024-12-04T18:48:56.3378052Z google.golang.org/grpc/test/bufconn.(*Listener).Accept(0x5b1ab00?)
Run tests	2024-12-04T18:48:56.3378385Z 	/home/runner/go/pkg/mod/google.golang.org/grpc@v1.67.1/test/bufconn/bufconn.go:61 +0x5e
Run tests	2024-12-04T18:48:56.3378685Z google.golang.org/grpc.(*Server).Serve(0xc0011d7200, {0x5ad99f0, 0xc0011f7100})
Run tests	2024-12-04T18:48:56.3378972Z 	/home/runner/go/pkg/mod/google.golang.org/grpc@v1.67.1/server.go:884 +0x46c
Run tests	2024-12-04T18:48:56.3379619Z github.com/smartcontractkit/chainlink-common/pkg/loop/internal/relayer
</cicore>
  
    
<operatoruici>

## AER Report: [Operator UI CI](https://github.com/smartcontractkit/chainlink/actions/runs/12163775491) ran successfully :white_check_mark:

[aer_workflow](https://github.com/smartcontractkit/chainlink/actions/runs/12163800741/job/33923877863) , [commit](https://github.com/smartcontractkit/chainlink/commit/814782a64b91338cb6f3c21ca2aa0047551499c1)

</operatoruici>

Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCIP uses QueryKey here 1, 2, 3, I don't see any tests failing but its worth double checking if this affects anything.
CC @winder

@EasterTheBunny EasterTheBunny force-pushed the etb/alter-default-sort-logpoller branch from 34461a1 to 814782a Compare December 4, 2024 16:11
@reductionista
Copy link
Contributor

I notice TestChainComponents/BatchGetLatestValues_for_EVM_on_loop/BatchGetLatestValues_works_for_EVM_on_loop is failing. This might be the test @ilija42 was mentioning it was originally updated for. Hopefully can just update the test to match the order?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants