Cappl 391 wire in workflow registry #15460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| custmsg.NewLabeler(), clockwork.NewRealClock(), keys[0]) | ||
|
|
||
| loader := syncer.NewWorkflowRegistryContractLoader(cfg.Capabilities().WorkflowRegistry().Address(), func(ctx context.Context, bytes []byte) (syncer.ContractReader, error) { | ||
| return relayer.NewContractReader(ctx, bytes) |
There was a problem hiding this comment.
You can simplify this to just relayer.NewContractReader I think?
There was a problem hiding this comment.
it needs to be the factory method, internally the workflow registry create this on demand am assuming for good reason
| }, eventHandler) | ||
|
|
||
| wfSyncer := syncer.NewWorkflowRegistry(globalLogger, func(ctx context.Context, bytes []byte) (syncer.ContractReader, error) { | ||
| return relayer.NewContractReader(ctx, bytes) |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
cedric-cordenier
previously approved these changes
Nov 29, 2024
kidambisrinivas
approved these changes
Nov 29, 2024
cedric-cordenier
approved these changes
Nov 29, 2024
EasterTheBunny
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves-> https://smartcontract-it.atlassian.net/browse/CAPPL-139