Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make centroid property of spectrum and not scan #499

Open
trishorts opened this issue Jul 17, 2019 · 2 comments
Open

Make centroid property of spectrum and not scan #499

trishorts opened this issue Jul 17, 2019 · 2 comments

Comments

@trishorts
Copy link
Contributor

image

@zrolfs
Copy link
Contributor

zrolfs commented Jul 17, 2019

I disagree. The spectrum is simply the array of peaks. All information surrounding the spectrum (RT, scan number, instrument, centroid/profile) should be in the MsDataScan. Why do you want this?

@trishorts
Copy link
Contributor Author

because the centroiding actually gets done in mzspectrum. So, seems like once it gets centroided, the variable should be set. The scan just takes what it gets. No point setting the centroid variable there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants