Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using standard bootstrap classes for AG feedback #18

Open
cycomachead opened this issue Feb 9, 2017 · 0 comments
Open

Switch to using standard bootstrap classes for AG feedback #18

cycomachead opened this issue Feb 9, 2017 · 0 comments

Comments

@cycomachead
Copy link
Member

.success translates to all tests passing
.warning translates to semi-passing or changes mage
.danger translates to failure?

Do we want to show red for failures?
We should only have 3 different states, IMO.

  • success, changes made, (semi-failing || all failing)
    OR
  • success, (changes made || semi-failing), all failing

Or we could just have 2 states which is nice and simple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cycomachead