Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert error in Literals.ml when calling E with trivial goal #99

Closed
nartannt opened this issue Jan 4, 2024 · 3 comments
Closed

Assert error in Literals.ml when calling E with trivial goal #99

nartannt opened this issue Jan 4, 2024 · 3 comments

Comments

@nartannt
Copy link
Contributor

nartannt commented Jan 4, 2024

When calling zipperposition (main branch) with the following options:
./zipperposition.exe --try-e [e-prover binary] --e-call-point 0.0 -t 30
on the following tptp file:
tff(goal, conjecture, ($true)).
It returns an assert error line 283 in Literals.ml

It seems that this is due to the Literals.Conv.to_tst function being called on an empty clause in eprover_interface.ml (line 136).

To the best of my understanding, since we have an empty clause, the assert false could be replaced by a false TypedSTerm:
| [] -> TypedSTerm.app_builtin ~ty Builtin.false_ []
this has fixed the problem for me, but I'm wary of the assert false being there in order to signal a soundness issue.

@abentkamp
Copy link
Collaborator

Sorry for the late reaction. Could you create a pull request? I'd be happy to merge it.

I assume the assert false is there because an empty clause would usually terminate the prover immediately. With --e-call-point 0.0 that does not happen, which is not ideal but acceptable, I think. I don't think you can get this issue with values larger than 0.0, can you?

@nartannt
Copy link
Contributor Author

nartannt commented Feb 8, 2024

Yes, I can make a pull request.

That's exactly what happens, if the prover is allowed to run any amount of time, it terminates instantly.

@nartannt
Copy link
Contributor Author

fixed in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants