Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1616500: Compatibility with urllib 2.2.2 #2016

Closed
GorbataiCristian opened this issue Aug 7, 2024 · 3 comments · May be fixed by #2029
Closed

SNOW-1616500: Compatibility with urllib 2.2.2 #2016

GorbataiCristian opened this issue Aug 7, 2024 · 3 comments · May be fixed by #2029
Assignees
@sfc-gh-yixie
Labels
duplicate This issue or pull request already exists enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@GorbataiCristian
Copy link

What is the current behavior?

snowflake-connector-python 3.12.0(latest version as of the creation of this issue) depends on urllib3<2.0.0 and >=1.21.1

What is the desired behavior?

snowflake-connector-python is compatible with urllib>2.0.0 (ideally 2.2.2)

How would this improve snowflake-connector-python?

urllib3<2.0.0 has potential security issues on some operating systems.
image

References and other background

I noticed a different issue that has the same goal, meaning a potential upgrade to the urllib version(this one). However, the reason for the request was different.
@github-actions github-actions bot changed the title Compatibility with urllib 2.2.2 SNOW-1616500: Compatibility with urllib 2.2.2 Aug 7, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hi - thanks for raising this request. let's see how #1998 fares.

@sfc-gh-dszmolka sfc-gh-dszmolka added enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage feature labels Aug 13, 2024
This was referenced Aug 17, 2024
Merged
Open
@jimmyxie-figma
Copy link

can we bump it further to 2.2.3 we have dependency conflict with dagster and that what dagster is on

@sfc-gh-dszmolka
Copy link
Contributor

closing as a duplicate of #1997

@sfc-gh-dszmolka sfc-gh-dszmolka added the duplicate This issue or pull request already exists label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-yixie sfc-gh-yixie

Labels
duplicate This issue or pull request already exists enhancement The issue is a request for improvement or a new feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testing urllib3 2.2.2 topherinternational/snowflake-connector-python
4 participants
@sfc-gh-dszmolka @GorbataiCristian @sfc-gh-yixie @jimmyxie-figma