Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL Audio ? #5

Open
delahee opened this issue Mar 3, 2016 · 3 comments
Open

SDL Audio ? #5

delahee opened this issue Mar 3, 2016 · 3 comments

Comments

@delahee
Copy link

delahee commented Mar 3, 2016

First, this is a nice binding working out of the box, congrats.

Seems to me there is no reference to SDL_OpenAudio. I need it for the ffmpeg binding.
Is it already done somewhere or should I send a pull request ?
( I'll start to write something while waiting for response )
Thanks and see ya!

@ruby0x1
Copy link
Member

ruby0x1 commented Mar 3, 2016

I haven't bound them yet, as you found.

A PR would be welcome, I worked backwards from the wiki by copy pasting and then doing them one by one in order of usage so I could test them in the test code.

One important note: I won't add any dependencies on this level - so as long as audio doesn't add other libs then just SDL itself - that's perfect.

@delahee
Copy link
Author

delahee commented Mar 3, 2016

Ok I think there is no deps but will keep in mind.
May I send PR as test goes or do you prefer a more massive PR we can
iterate on ?

Thx
Le 3 mars 2016 21:15, "Sven Bergström" notifications@github.com a écrit :

I haven't bound them yet, as you found.

A PR would be welcome, I worked backwards from the wiki
https://wiki.libsdl.org/CategoryAudio by copy pasting and then doing
them one by one in order of usage so I could test them in the test code.

One important note: I won't add any dependencies on this level - so as
long as audio doesn't add other libs then just SDL itself - that's perfect.


Reply to this email directly or view it on GitHub
#5 (comment).

@ruby0x1
Copy link
Member

ruby0x1 commented Mar 3, 2016

It's ok, it doesn't have to be the whole of the audio API to PR.

If you only need a few functions to get what you need,
you can PR those and I'll get around to the rest at some point too.

jeremyfa pushed a commit to ceramic-engine/linc_sdl that referenced this issue Sep 15, 2019
Fix dual-monitor support on Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants