Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not actually generate valid Markdown for bold, italic or bold-italic #186

Open
richjeffery opened this issue Nov 13, 2017 · 1 comment

Comments

@richjeffery
Copy link

richjeffery commented Nov 13, 2017

There's an issue in the rendering of Markdown for Bold, Italic or Bold-Italic.

The Markdown clearly specification states that *Italic* should produce italic, **bold** will produce bold, and therefore ***bold-italic*** produces bold-italic .

However, there is code in pen.js that states 'italic' is ***italic*** and bold-italic is **bold-italic** which is wrong (it produces Bold-Italic and Bold respectively).

If you pasted the result of the generated code into any markdown processor it would not reproduce what you'd typed correctly.

@richjeffery
Copy link
Author

richjeffery commented Nov 13, 2017

For reference:

  • line 827: i: [/<i\b[^>]*>(.*?)<\/i>/ig, '***$1***'], and
  • line 847: return html.replace(/\*{5}/g, '**');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant