-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GestureHandlerRootView interferes with text selection inside webview during Android back gesture #3196
Comments
You would think if you're clever enough you could work around this, but it does not appear to be the case. Even if you can detect this occurring, the Webview will still respond to the touch event if you set |
If Android would let you persist the keyboard, it would be hard to work around this - but without that capability it's impossible to do anything that feels much less janky than the bug itself does. |
I know it's been like 18 hours, but early bump because I've spent probably 60 hours on this issue. |
Hi @Nantris! I've just tested this on the following devices:
|
Thanks for your reply @m-bert! I'll provide a video of exactly what I mean as soon as I can. I can produce this on all devices that use the gesture navigation (most recently tested on Galaxy S24.) |
Apologies that I couldn't capture a screen recording sooner. Hopefully this will clarify the problematic behavior @m-bert. Apologies also for the oddly dark videos. Working normally without
|
Which version of React Native do you use? |
Thanks for your reply @m-bert. It's I think the Expo Snack uses |
To clarify, the version we use is |
I've just tested that on Pixel 6 (physical device) and I got exactly what on emulator - no zoom bubble. |
Thanks for continuing to look into this @m-bert. The manifestations can be a bit different depending on the exact gesture and underlying content, but it should be reproducible across devices. Possible outcomes are:
I accidentally left the repro in a state where the bug would not be reproduced which could be to blame (I commented out This is a screen recording from my Pixel 4a running Android 13: screen-20241108-134634.mp4I'll also upload a screen recording from an emulator when I'm back at my PC. Thank you so much again for taking a look at this! |
On a Pixel 8 emulator running Android 14: The text zoom bubble outcome seems less likely here, but the expanded text selections occur. Android-back-gesture-interference.mp4 |
Thanks again for your replies @m-bert! I wonder if you've had a chance to take a look at the additional videos and I wonder if the failure to reproduce on your end might be due to subtle differences in the gestures we're doing. When I produce the issue, the user begins a back gesture (let's say possibly by accident) - holds it for a moment - and then swipes back towards the edge to cancel it. Is that already what you're doing? If you're not able to reproduce it, I wonder if you could share a screen recording and maybe I could identify a discrepancy between our two methods that leads to it not reproducing on your end. Thanks for the great work and again for taking the time to take a look at this issue in the first place. |
Is there anything I can do to help move this forward? It's presenting real usability issues for us and unfortunately it's entirely impossible to work around from our side - especially since |
Hi @Nantris! I've been really busy this week so I didn't have a chance to look at it. I'll try to get back to it today and take a video of my emulator. |
Okay, I've tried it on another emulator and I've finally managed to reproduce it. I'll look into it and get back to you when I find something 😅 |
Thanks so much for taking a look into this @m-bert; I really appreciate it! Please let me know if I can be of assistance in any way! |
Hi @Nantris! To keep you updated, I've managed to get rid of the text selection and other problems. However, it is a tricky way and I'm not yet sure if we are supposed to do this. We will talk about it on Monday meeting 😅 |
Thank you so much again for looking into this @m-bert! It's exciting to hear about a potential solution.
Isn't that just programming? Am I doing it wrong? 😅 |
Description
When doing a back gesture in Android - the
GestureHandlerRootView
causes bugs interacting with the underlying Webview and they do not seem to be avoidable and are without any workaround. This makes things feel beyond janky.Steps to reproduce
BuggyApp
and enable the alternative versionWorkingApp
to see the intended behavior (text selection may change still, but will not set expanded text selections or cause text zoom bubble to appear)Snack or a link to a repository
Snack repro
Gesture Handler version
2.20.2
React Native version
0.72.x through 0.76.x
Platforms
Android
JavaScript runtime
Hermes
Workflow
Expo managed workflow
Architecture
Paper (Old Architecture)
Build type
None
Device
Real device
Device model
Galaxy S24 (Android 14) -- Reproducible on all Android devices using gestures
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: