Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using OOP [class y extends x] to build on existing code: from example to real world application #56

Open
MayaGans opened this issue Jul 16, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@MayaGans
Copy link
Collaborator

The examples in the OOP chapter does a great job introducing the user but we should highlight how the original class doesn't have to be written by the user (Maybe I assumed this because the examples start from scratch?), and I think make sure it's in bold font how we don't need to fork and mess with original packages but can use OOP to extend them to do what we want

Example: I thought I needed to fork data-forge in order to create a new method myGroupBy within dataForge.DataFrame, not fully grasping that I could write

class MyDF extends dataForge.dataFrame {
    myGroupBy()....
}

I think if we include an example, aside, or even an exercise asking the reader to extend a data science related package to have a new/modified method it'll help to contextualize when they'll be using this.

@gvwilson
Copy link
Collaborator

Do you have an example in mind for this, or should we turn it into an exercise?

@gvwilson gvwilson added the enhancement New feature or request label Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants