Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup identification of github URLs #13

Open
npch opened this issue Mar 28, 2018 · 2 comments
Open

Cleanup identification of github URLs #13

npch opened this issue Mar 28, 2018 · 2 comments

Comments

@npch
Copy link
Member

npch commented Mar 28, 2018

Currently, we grab all github urls including blobs and duplicates. We should remove these (unless we are trying to test for stickiness of blobs).

@andreww
Copy link

andreww commented Mar 31, 2018

I think we should probably keep these, and do some "identification" of link type early in the processing workflow. It may be useful to know how many links are to blobs, and how many are to the base repository (or to a user page), for example.

@npch
Copy link
Member Author

npch commented Apr 2, 2018

Commit efecff0 cleans up duplicate URLs.

Adding an identification of the link type shouldn't be a problem, but will break the data structure we are currently using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants