Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Deploy to AWS with SST #921

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Docs: Deploy to AWS with SST #921

merged 12 commits into from
Oct 31, 2024

Conversation

jayair
Copy link
Contributor

@jayair jayair commented Oct 15, 2024

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

A doc on how to deploy SolidStart to AWS with SST. I tried it locally and it looked good.

Copy link

stackblitz bot commented Oct 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit a628f87
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6722147e14dff70008f70a28
😎 Deploy Preview https://deploy-preview-921--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) October 16, 2024 14:49
@LadyBluenotes
Copy link
Member

Thank you for this @jayair !

@atilafassina
Copy link
Member

Hello @jayair

First of all, thank you very much for this contribution.
I just fixed the build step (there was an outdated pnpm-lock.yaml breaking things.

I also adjusted some formatting and added tabbed code blocks for pnpm, yarn, and bun on top of npm.

I'd like to wait on your go-ahead before merging it, with the build working, you should be able to review it more easily now.

@jayair
Copy link
Contributor Author

jayair commented Oct 30, 2024

Thank you!

Yeah it looks great!

@atilafassina atilafassina merged commit 51f3ec2 into solidjs:main Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants