Fix pnpm command and first tsx example in typescript.mdx #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pnpm tsc` is the correct way to invoke the typescript compiler. `pnpm dlx tsc` yields a "This is not the tsc command you are looking for" error message. Changed the function to be type 'Component' as imported, rather than returning the unimported 'JSX.Element' type. Also added some semicolons.
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LadyBluenotes
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description(required)
pnpm tscis the correct way to invoke the typescript compiler for pnpm.pnpm dlx tscyields a "This is not the tsc command you are looking for" error message. Changed the function in the first tsx example to be typeComponentas imported, rather than returning the unimportedJSX.Elementtype. Also added some semicolons.Related issues & labels
N/A