Replies: 2 comments 2 replies
-
|
This feature was provided by Vite: https://github.com/vitejs/vite/blob/c0ec6bea69b6160553f4a5b30652dcef891788fc/packages/vite/src/node/plugins/importAnalysisBuild.ts What benefits does nitro/vinxi's manual asset handling provide? |
Beta Was this translation helpful? Give feedback.
-
|
I don't think Vite waits.. the router and vite have no way of knowing about each other. Vite does handle adding it but if it was loading beforehand it was by chance I think. |
Beta Was this translation helpful? Give feedback.
-
|
That plugin works on all dynamic imports, old Solid Start file system router generates dynamic imports, so it works out-of-the-box. In fact, in current Solid Start version, you only need to replace with const mod = await component.build()Vinxi generates the I created this minimal repro: https://github.com/yume-chan/solid-start-wait-assets If you start it normally with Recording.2024-04-29.143748.mp4But if you execute Recording.2024-04-29.143903.mp4 |
Beta Was this translation helpful? Give feedback.
-
|
With minification disabled, the generated router manifest is const __vite__fileDeps=["assets/about-BzjT0PMC.js","assets/index-CXvkaZX7.js","assets/about-CyiT_ioQ.css","assets/index-CuOQb2Au.js","assets/routing-CH2plF5P.js","assets/index-7whypOeP.css","assets/_...404_-DQ7qBchp.js","assets/HttpStatusCode-B9tIHqYd.js"],__vite__mapDeps=i=>i.map(i=>__vite__fileDeps[i]);
// [omitted]
const fileRoutes = [{
"$component": {
"src": "src/routes/about.tsx?pick=default&pick=$css",
"build": () => __vitePreload(() => import(
/* @vite-ignore */
'./about-BzjT0PMC.js'
),true?__vite__mapDeps([0,1,2]):void 0),
"import": () => {
const id = "src/routes/about.tsx?pick=default&pick=$css";
return __vitePreload(() => import(
/* @vite-ignore */
globalThis.MANIFEST["client"].inputs[id].output.path
),true?[]:void 0);
}
},
"path": "/about",
"filePath": "D:/dev/sandbox/wait-assets/wait-assets/src/routes/about.tsx"
// [omitted]
}];in Source code of |
Beta Was this translation helpful? Give feedback.
-
I'm migrating my old Solid Start project to beta 2, and I noticed now it has a huge FOUC when switching routes.
I checked the old code, seems like it inserts all
<link rel="stylesheet" >into<head>, wait for them to load, then replaces route content.Why doesn't it do that now? I think the user experience is worse especially with slow networks (I know it adds preloads, but the user can still switch routes before preloads are loaded)
Beta Was this translation helpful? Give feedback.
All reactions