Update support to latest requirements for extensions #177
Conversation
mergify
bot
added
the
needs changelog label
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
cpfergus1
force-pushed
the
update-support-to-latest-requirements-for-extensions
branch
from
4f667fb
to
53c5363
Compare
elia
force-pushed
the
update-support-to-latest-requirements-for-extensions
branch
from
53c5363
to
f8cbc61
Compare
|
@cpfergus1 I rebased this on top of #188, since they were touching similar files, once that's merged we can rebase on master and merge it if everything checks. |
elia
force-pushed
the
update-support-to-latest-requirements-for-extensions
branch
from
f8cbc61
to
8085b28
Compare
Ruby 2.5 has reached EOL and will no longer recieve any security patches. Bumped version requirements to 2.6 as it is best practiced to use a maintained version of Ruby. Ruby 2.6 EOL slated for March 31, 2022
The bug that this code fixed has been patched in the the latest versions of bundler and is no longer required.
The command `solidus extension .` may not work directly on some machines without `bundle exec`. Updated to be more explicit and prevent possible confusion.
elia
force-pushed
the
update-support-to-latest-requirements-for-extensions
branch
from
8085b28
to
c5bcda0
Compare
elia
added
enhancement
| # A workaround for https://github.com/bundler/bundler/issues/6677 | ||
| gem 'rails', '>0.a' | ||
|
|
There was a problem hiding this comment.
One thing we've noticed on solidus_taxjar when we removed Rails from the Gemfile is that it exposed an issue upstream with active_storage. It is explicitly required here however it isn't listed as one of the Rials gems that are dependencies of core here. I still think this change is good, however if you see failures booting the dummy app, this could be the culprit. I believe this should be fixed upstream in core however.
| @@ -42,7 +42,7 @@ If you have an existing extension and want to update it to use the latest standa | |||
| you can run the following in the extension's directory: | |||
|
|
|||
| ```console | |||
| $ solidus extension . | |||
| $ bundle exec solidus extension . | |||
There was a problem hiding this comment.
Thanks for clarifying this!
I think we may want to also clarify in the section above on generating a new extension, that this gem needs to be installed globally (i.e. gem install solidus_dev_support in order for the the solidus executable to be added to the path. The installation instructions only focus on adding this as a dependency of an existing extension, which I think is causing some of the confusion.
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Summary
Updated Readme with more explicit shell command for running
solidus extension .Removed
rails > 0.a, bundler has been patched to prevent the issue with resolving dependencies.Bumped Ruby from 2.5 to 2.6, Ruby 2.5 EOL was April 1st 2021, and 2.6 EOL is slated for March 31st 2022
Checklist