Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable venmo #136

Open
2 tasks
DanielePalombo opened this issue Nov 22, 2021 · 1 comment
Open
2 tasks

Enable venmo #136

DanielePalombo opened this issue Nov 22, 2021 · 1 comment
Assignees
Labels

Comments

@DanielePalombo
Copy link
Contributor

In order to enable Venmo button, we have to add the enable-funding=venmo parameter to the SDK script js.

ref https://github.com/solidusio-contrib/solidus_paypal_commerce_platform/blob/3a5f97d33c42f4123d737b58a46809de488b9090/app/models/solidus_paypal_commerce_platform/payment_method.rb#L77

@DanielePalombo DanielePalombo self-assigned this Nov 22, 2021
RyanofWoods added a commit to RyanofWoods/solidus_paypal_commerce_platform that referenced this issue Nov 22, 2021
Resolves issues/tickets:
- solidusio#136
- solidusio#137

Setting the preference enable_venmo to true will now show a Venmo button
on checkout for customers whom it is available to.

For testing purposes, the string preference force_buyer_country was
added. You can use this to mock what country the buyer is from, allowing
you to see what funding sources are shown to customers in various
countries.

This preference does not affect checkout on production, environment.
Instead, PayPal will get this information from their ip geolocation.

More information:
https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#buyer-country
RyanofWoods added a commit to RyanofWoods/solidus_paypal_commerce_platform that referenced this issue Nov 23, 2021
Resolves issue/ticket:
- solidusio#136

Setting the payment method preference `enable_venmo` to true will now
show a Venmo payment option on checkout for customers whom it is
available to (currently only US).
RyanofWoods added a commit to RyanofWoods/solidus_paypal_commerce_platform that referenced this issue Nov 26, 2021
Resolves issue/ticket:
- solidusio#136

Setting the payment method preference `enable_venmo` to true will now
show a Venmo payment option on checkout for customers whom it is
available to (currently only US).
RyanofWoods added a commit to RyanofWoods/solidus_paypal_commerce_platform that referenced this issue Dec 2, 2021
Resolves issue/ticket:
- solidusio#136

Setting the payment method preference `enable_venmo` to true will now
show a Venmo payment option on checkout for customers whom it is
available to (currently only US).
RyanofWoods added a commit to RyanofWoods/solidus_paypal_commerce_platform that referenced this issue Dec 2, 2021
Resolves issue/ticket:
- solidusio#136

If a transaction meets Venmo prerequisites [1], then Venmo button
should appear already on checkout, cart and product page depending
on payment method preferences.

These changes is to give more control to the developer so that they can
disable Venmo by setting the `enable_venmo` to false.
https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#disable-funding

As it Venmo may have already been showing for developers, the default
was set to true.

The enable-funding option is now also sent over to ensure that the Venmo
button gets rendered if eligible:
https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#enable-funding
https://developer.paypal.com/docs/business/checkout/pay-with-venmo/integrate-pay-with-venmo/#always-request-venmo

[1] https://developer.paypal.com/docs/business/checkout/pay-with-venmo/#eligibility
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant