-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gem does not support Ruby 3.0 #145
Comments
This reverts commit c975572. Temporary solution for issue: solidusio#145
This reverts commit c975572. Temporary solution for issue: solidusio#145
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It might be closed if no further activity occurs. Thank you for your contributions. |
Almost a year passed, no progress on this breaking issue? Why does bundler not recognize the conflict for me?
And it installs without complaint... What do I do now, I want to start using the store in a few days? |
apparently the upstream issue is fixed: paypal/paypalhttp_ruby#12 See also solidusio/solidus#4494 May be fixed by #161 |
Can this be closed now @cpfergus1 and @elia? |
@RyanofWoods for sure, master is testing against ruby 2.7, 3.0, and 3.1 👍👍👍 |
General information:
This gem has a dependency of paypal-checkout-sdk which has a dependency of paypal-http, both of these gems do not support Ruby 3.0 yet. This is causes issues as seen here: #132
Example:
The above issue highlights that the incompatiblity causes issues with our execute method, which is a core method in the gem. This trickles down to
URI.escape
method used in paypal-http.This has been "deprecated" for 10 years and removed in Ruby 3.0
paypal-http
has an issue for the Ruby 3.0 incompatibility : paypal/paypalhttp_ruby#12The mentioned dependencies might not be the only dependencies that does not support Ruby 3.0, so this should be investigated further.
Proposed solution:
As soon as the PayPal dependencies are compatible with Ruby 3.0 we should attempt to make the gem compatible with it as well.
Temporary solution:
The
required_ruby_version
in thegemspec
has been rollbacked to pre 3.0 to prevent developers having the same issue.The text was updated successfully, but these errors were encountered: