Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Sentry exception logging #78

Closed
pushred opened this issue Dec 16, 2013 · 2 comments
Closed

Support for Sentry exception logging #78

pushred opened this issue Dec 16, 2013 · 2 comments

Comments

@pushred
Copy link
Member

pushred commented Dec 16, 2013

Preprocessors aren't always written perfectly and may result in exceptions that take down a page's context. Sentry offers a great way to track such exceptions across many projects. Unlimited projects, team members, and open source instrumentation make Sentry highly competitive amongst it's competition.

Implementation as middleware seems straightforward. Presence of the SENTRY_DSN environment variable would be a good way to easily turn this logging on & off, in conjunction with setting these variables with hosts such as Modulus, Heroku, and Nodejitsu.

@Fauntleroy
Copy link
Contributor

With all this talk of ENV variables I'm starting to think we might want to develop a strategy for configuration. What goes into JSON vs ENV? Are there cases where something can be configured in both? What takes precedence?

@pushred
Copy link
Member Author

pushred commented Jan 8, 2014

Using SENTRY_DSN variable is a feature of the Raven clients, reducing our work to be done here, but it does dovetail nicely with the strategy in #75. If you follow the idea of a project-scoped file vs. the shell config you would want to pass any SENTRY_DSN value specified there to the middleware vs. anything defined in the shell. The latter should still work as a fallback though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants