"show queue counters" does not show stats for all queues with traffic

[prabhataravind]

With the introduction of changes via PR sonic-net/sonic-swss#2474, "show queue counters" shows stats only for queues that are configured via config DB. This has created a regression where ports with active traffic do not show up in "show queue counters" if they are missing in config DB. A couple of such examples are:

1. UC7 queue which is used as the default queue for all control traffic
2. Multicast queues with non-zero counters

I have verified with a sonic image without the changes from PR 2474 that these counters show up and they go missing when these changes are added back.

"show queue counters" without the changes from PR 2474:

Port TxQ Counter/pkts Counter/bytes Drop/pkts Drop/bytes

---

Ethernet124 UC0 0 0 0 0
Ethernet124 UC1 0 0 0 0
Ethernet124 UC2 0 0 0 0
Ethernet124 UC3 0 0 0 0
Ethernet124 UC4 0 0 0 0
Ethernet124 UC5 0 0 0 0
Ethernet124 UC6 0 0 0 0
Ethernet124 UC7 413 410082 0 0 <<<<<<<<<<
Ethernet124 UC8 0 0 0 0
Ethernet124 UC9 0 0 0 0
Ethernet124 MC10 0 0 0 0
Ethernet124 MC11 2849 267806 0 0 <<<<<<<<<<
Ethernet124 MC12 0 0 0 0
Ethernet124 MC13 0 0 0 0
Ethernet124 MC14 0 0 0 0
Ethernet124 MC15 0 0 0 0
Ethernet124 MC16 0 0 0 0
Ethernet124 MC17 0 0 0 0
Ethernet124 MC18 0 0 0 0
Ethernet124 MC19 0 0 0 0

"show queue counters" with changes from PR 2474:

Port TxQ Counter/pkts Counter/bytes Drop/pkts Drop/bytes

---

Ethernet124 UC0 0 0 0 N/A
Ethernet124 UC1 0 0 0 N/A
Ethernet124 UC2 0 0 0 N/A
Ethernet124 UC3 0 0 0 N/A
Ethernet124 UC4 0 0 0 N/A
Ethernet124 UC5 0 0 0 N/A
Ethernet124 UC6 0 0 0 N/A

[prabhataravind]

@prsunny for viz

[prsunny]

@vadymhlushko-mlnx , @liat-grozovik, @shlomibitton for viz. We would have to revert the PR as it is a regression

[vadymhlushko-mlnx]

@prabhataravind could you please tell me exactly which SONiC image versions you compared?
And also could you please attach the techsupport dump from both SONiC image versions?

[abdosi]

@vadymhlushko-mlnx what is latest on this ? Without this we are not able to see UC7 queue counters value.

[prabhataravind]

@prabhataravind could you please tell me exactly which SONiC image versions you compared? And also could you please attach the techsupport dump from both SONiC image versions?

Hi @vadymhlushko-mlnx , the issue is seen on any device running the latest 202205 sonic image. It should be fairly easy to see the problem by running "show queue counters" on the latest 202205 image. The tech support dump is too big to be attached here. This issue is not present in 202012. I remember I also verified by checking out a 202205 swss commit SHA before sonic-net/sonic-swss#2474 changes went in.

[prsunny]

blocking sonic-net/sonic-mgmt#8097

[liat-grozovik]

@prabhataravind @prsunny long time ago we agreed that issues will be opened on sonic-buildimage so we can have one way to find all issues and not per repro. Should we move it?

[rlhui]

@vadymhlushko-mlnx , please provide link to PR for the fix? thanks.

[rlhui]

Fixes for 202205 branch:
sonic-net/sonic-swss#2882
#16232

[rlhui]

@prabhataravind please help check if this issue can be closed? Thanks.

[prabhataravind]

[like] Prabhat Aravind reacted to your message:

…

________________________________ From: Rita Hui ***@***.***> Sent: Thursday, December 7, 2023 2:56:02 AM To: sonic-net/sonic-buildimage ***@***.***> Cc: Prabhat Aravind ***@***.***>; Mention ***@***.***> Subject: Re: [sonic-net/sonic-buildimage] "show queue counters" does not show stats for all queues with traffic (Issue #16202) @prabhataravind<https://github.com/prabhataravind> please help check if this issue can be closed? Thanks. — Reply to this email directly, view it on GitHub<#16202 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZ4G37QC2SHT73NAJPPMGZTYIEV4FAVCNFSM6AAAAAA3U7ANJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBUGE2DGMJSGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>