Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flask, Flask Restx, unpin Gilda #1452

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Update Flask, Flask Restx, unpin Gilda #1452

merged 7 commits into from
Jul 19, 2024

Conversation

kkaris
Copy link
Member

@kkaris kkaris commented Jul 2, 2024

This PR updates the extras requirements in setup.py to resolve #1448.

Resolves #1448.

Todo

  • Revisit the cython and pyjnius upgrade: It was necessary to get Python 3.10 working in Upgrade to flask_jwt_extended>3 gyorilab/indra_cogex#172, but since downgrading to python 3.8 (via use of ubuntu 20 as base image) this might not be necessary any longer. Leaving the cython and pyjnius versions untouched would be the more conservative approach (don't fix what ain't broken...) Fixed in 90eba2c

Update 7/8 2024
Code is tested with gyorilab/indra_cogex#172 and gyorilab/ui_util#20, but not yet with gyorilab/emmaa#280 or a new deployment of db.indra.bio on lambda+api gateway.

Update 7/11 2024
Code has been tested and is used in production for EMMAA using Python 3.9.

Update 7/18 2024
Code has been tested and is used in the dev deployment for INDRA DB.

@kkaris kkaris marked this pull request as ready for review July 18, 2024 20:51
@kkaris
Copy link
Member Author

kkaris commented Jul 18, 2024

The only two tests failing are in indra_db_rest (they timed out)

@bgyori bgyori merged commit 3c232fb into master Jul 19, 2024
2 of 4 checks passed
@kkaris kkaris deleted the gilda-flask-deps branch July 19, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask>=3 requires changes to flask-jwt-extended usage
2 participants