Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

Align Python Chart library with Odyssey Hackathon UI #29

Open
mortonanalytics opened this issue May 7, 2019 · 2 comments
Open

Align Python Chart library with Odyssey Hackathon UI #29

mortonanalytics opened this issue May 7, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mortonanalytics
Copy link
Contributor

mortonanalytics commented May 7, 2019

For @mzargham to perform subgraph review, the Python chart library needs to better align with the Odyssey Hackathon UI. From what I can see so far:

1. Force simulation needs to scale to subgraph data sizes (100 or less nodes); DONE
2. Add halo as a click event on the node DONE
3. Add labels (conditional on size, maybe on hover...)
4. Fix popover to display node data (maybe merge with #3)

I'm assigning this to myself, but help is welcomed!

@mortonanalytics mortonanalytics added the enhancement New feature or request label May 7, 2019
@mortonanalytics mortonanalytics self-assigned this May 7, 2019
@teamdandelion
Copy link
Contributor

I've been working on porting the Odyssey UI into sourcecred/sourcecred. You can see the work in progress here and you can give it a live run by cloning that branch, running yarn start, and going to localhost:8080/odyssey-graphviz/

It's in a pretty good shape, in that it has tooltips and the basic functionality, and is in a pretty cleanly architected React-like approach. I'm hoping to merge it into the codebase proper before long.

@mortonanalytics
Copy link
Contributor Author

Awesome! I'll work from there rather than the hackathon code. Thanks!

mortonanalytics added a commit that referenced this issue May 9, 2019
mortonanalytics added a commit that referenced this issue May 9, 2019
mortonanalytics added a commit that referenced this issue May 19, 2019
* add JS for simulation, halo, and tooltip

relates to #29

* correcting previous commit

* code cleanup

* code review changes

this commit reflects changes requested upon code review from @decentralion: variable declaration, using => for functions, removing unneccessary comments, and some other substantive changes. I also changed naming conventions from 'd3' to just the function name since I don't need to identify d3 DOM manipulation functions anymore. I also changed 'if' statements to switch calls for easier reading.

* remove unhelpful comments

* remove 'rMorton' folder from this repo
wchargin pushed a commit that referenced this issue Sep 11, 2019
wchargin pushed a commit that referenced this issue Sep 11, 2019
* add JS for simulation, halo, and tooltip

relates to #29

* correcting previous commit

* code cleanup

* code review changes

this commit reflects changes requested upon code review from @decentralion: variable declaration, using => for functions, removing unneccessary comments, and some other substantive changes. I also changed naming conventions from 'd3' to just the function name since I don't need to identify d3 DOM manipulation functions anymore. I also changed 'if' statements to switch calls for easier reading.

* remove unhelpful comments

* remove 'rMorton' folder from this repo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants