Chat: register webview #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
commented
Aug 13, 2024
| @@ -85,14 +90,15 @@ public void RegisterWebview(string handle) | |||
| [JsonRpcMethod("webview/registerWebviewViewProvider")] | |||
| public async Task RegisterWebviewViewProvider(string viewId, bool retainContextWhenHidden) | |||
| { | |||
| System.Diagnostics.Debug.WriteLine(viewId, retainContextWhenHidden, "Agent registerWebviewViewProvider"); | |||
| agentClientReady.Task.Wait(); | |||
There was a problem hiding this comment.
this makes sure agentClient is initialized and ready before we send the request to agent
PiotrKarczmarz
approved these changes
Aug 13, 2024
| await InitializeService.Initialize(AgentService); | ||
| NotificationHandlers.SetAgentClient(AgentService); |
There was a problem hiding this comment.
It's better to call SetAgentClient before the agent initialization.
There was a problem hiding this comment.
The html will not start if i set agent client in Notification handlers before agent is initialized because some of the notifications were dropped? 🤔
There was a problem hiding this comment.
Ok, let's leave it as it is for now.
tomaszgolebiowski
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run client.ResolveWebviewView after client has been initialized.