Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix storybook build (pnpm -C web dev) #5667

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix storybook build (pnpm -C web dev) #5667

merged 3 commits into from
Sep 23, 2024

Conversation

beyang
Copy link
Member

@beyang beyang commented Sep 23, 2024

For reasons I don't fully understand, these imports were causing the storybook build (pnpm -C web dev) to fail. It looks like the re-exported symbols in question (modelsService, CodyClientConfig) were stripped but then later expected from within Storybook, which caused errors like this:

Uncaught SyntaxError: The requested module '/@fs/home/beyang/src/github.com/sourcegraph/cody/lib/shared/src/models/modelsService.ts' does not provide an export named 'ModelCategory' (at index.ts:7:5)

Test plan

Dev-only

@beyang beyang requested a review from sqs September 23, 2024 19:40
@beyang beyang enabled auto-merge (squash) September 23, 2024 19:52
@beyang beyang merged commit 6232942 into main Sep 23, 2024
18 checks passed
@beyang beyang deleted the bl/fix-storybook branch September 23, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants