Hitesh/vscode 1.36.3 release #5813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No functional changes. - Re-enabled existing autocomplete integration tests and improved the stability of recoding updates. Initially, they were disabled here: #5629 - Replaced most of the `sleep` calls with new agent `testing/X` requests to await for a timeout in question ([Slack thread](https://sourcegraph.slack.com/archives/C0729T2PBV2/p1727834492679739)). - Removed the `NoopCompletionItemProvider` registration for unauthenticated users to fix the flaky behavior where the real autocomplete provider was not registered before the first `autocomplete/execute` call in tests ([Slack thread](https://sourcegraph.slack.com/archives/C05AGQYD528/p1727836036656949)). Autocomplete is currently available only for authenticated requests, so this change should not have any functional side effects.
Use the current document for tracking the insertText. Using the pre-calculated text was making the offline diffs inaccurate, as introduced in the [PR](https://github.com/sourcegraph/cody/pull/5767/files). ## Test plan CI checks
abeatrix
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick
Test plan
cherry-pick, updated changelog and version