fix agent tests model preferences state #5828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is [not used in JetBrains](https://sourcegraph.com/search?q=repo:sourcegraph/jetbrains+chat/restore&patternType=keyword&sm=0) and was marked for deletion 2 months ago.
Also `console.debug` is not supported everywhere, so just use `console.log`.
In the agent tests, the `testing/reset` command was not entirely resetting the state between tests. This meant that 2 tests (explain and smell) that performed explicit `chat/setModel` requests to change the model to Mixtral were running with the chat model used for the previous tests. The reason is that `testing/reset` just cleared the in-memory `LocalStorageProvider` backing `Map` and did not cause `LocalStorageProvider` to fire a change event, which is necessary for the `ModelsService` to know that the models preferences changed. Also clean up types.
beyang
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the agent tests, the
testing/resetcommand was not entirely resettingthe state between tests. This meant that 2 tests (explain and smell) that
performed explicit
chat/setModelrequests to change the model to Mixtral butwere (incorrectly) running with the chat model used for the previous tests.
The reason is that
testing/resetjust cleared the in-memoryLocalStorageProviderbackingMapand did not causeLocalStorageProviderto fire a change event, which is necessary for theModelsServiceto know that the models preferences changed.Also clean up types.
Test plan
Agent tests