Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoedit): fix cursor jumping issue #6156

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

hitesh-1997
Copy link
Contributor

Using absolute position for the decoration to prevent cursor from jumping.

Loom.Message.-.20.November.2024.mp4

Test plan

Used rendering examples from cody-chat-eval. See video attached for the examples.

@beyang
Copy link
Member

beyang commented Nov 20, 2024

image

the dotted green line here should extend to the upper-right corner of the added block

Copy link
Member

@beyang beyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to fix the dashed green line insert marker rendering issue, but I don't think it warrants blocking this PR.

@valerybugakov valerybugakov merged commit a36c585 into main Nov 20, 2024
18 of 20 checks passed
@valerybugakov valerybugakov deleted the hitesh/fix-autoedit-cursor-jump-issue branch November 20, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants