Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert open telemetry integration #6100 #6179

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

vovakulikov
Copy link
Contributor

Revert of #6100

#6100 introduces Cody Web regression because it pulls into the bundle zlib, and apparently, the zlib browser version doesn't work in the web-worker context. Hence, we have a runtime error. I suggest we revert changes from #6100 and investigate more into what exactly is happening in web-worker Cody's Web bundle with the new open telemetry reporter.

Uncaught TypeError: Cannot read properties of undefined (reading 'prototype')
    at ../../../cody/web/dist/agent.worker-Cnq9eXnn.mjs (50be7d08-d01b-472b-8932-6af884d43a68:488831:61)
    at __init (50be7d08-d01b-472b-8932-6af884d43a68:11:56)
    at 50be7d08-d01b-472b-8932-6af884d43a68:501380:1

Test plan

  • Check that Cody Web demo works (meaning has no runtime error on initial run)

@vovakulikov vovakulikov requested a review from a team November 22, 2024 15:27
@vovakulikov vovakulikov self-assigned this Nov 22, 2024
@vovakulikov vovakulikov merged commit 333f40d into main Nov 22, 2024
19 of 20 checks passed
@vovakulikov vovakulikov deleted the vk/revert-open-telemetry-integration-6100 branch November 22, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants