space_robots Dockerfile includes TODO, commented code

[ivanperez-keera]

We should avoid leaving todos in code, that's just a recipe for never doing anything about those issues ever.

The following TODO note should be transformed into an issue, or solved.

docker/space_robots/Dockerfile

Lines 49 to 60 in 76cd412

	# TODO(anyone): remove demo-pkgs.txt, no packages left after exclusions
	# Generate repos file for demo dependencies, excluding packages from Space ROS core.
	# COPY --chown=${USERNAME}:${USERNAME} demo-pkgs.txt /tmp/
	# COPY --chown=${USERNAME}:${USERNAME} excluded-pkgs.txt /tmp/
	# RUN rosinstall_generator \
	# --rosdistro ${ROSDISTRO} \
	# --deps \
	# --exclude-path ${SPACEROS_DIR}/src \
	# --exclude-path ${MOVEIT2_DIR}/src \
	# --exclude $(cat /tmp/excluded-pkgs.txt) -- \
	# -- $(cat /tmp/demo-pkgs.txt) \
	# > /tmp/demo_generated_pkgs.repos

The following commented code should also be removed (it's duplicated below):

docker/space_robots/Dockerfile

Line 76 in 76cd412

# RUN vcs import src < /tmp/demo_generated_pkgs.repos

[ivanperez-keera]

I can also turn this issue into one that describes the very problem that the TODO is trying to point at. But if it's not trivial to fix, then I'd rather get the TODO removed and then we can deal with the issue separately.

[SEC-RKatayama]

[like] 片山 諒介 reacted to your message:

…

________________________________ From: Ivan Perez, PhD ***@***.***> Sent: Wednesday, January 10, 2024 9:09:35 AM To: space-ros/docker ***@***.***> Cc: Subscribed ***@***.***> Subject: [space-ros/docker] `space_robots` `Dockerfile` includes TODO note (Issue #102) We should avoid leaving todos in code, that's just a recipe for never doing anything about those issues ever. The following TODO note should be transformed into an issue, or solved. https://github.com/space-ros/docker/blob/76cd412a7379dd5a5ec338b7b75659afbbf0c9a1/space_robots/Dockerfile#L49-L60 — Reply to this email directly, view it on GitHub<#102>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BB2S22MZCD4FU7S4BLFTEM3YNZLE7AVCNFSM6AAAAABBUNUM4WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TGOJRGQZDAMY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[mkhansenbot]

I agree we should remove all TODO and "dead code" or commented out code. If it's a REAL issue, we should file an issue to track it.