Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendorize and fix contexts workflow #518

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 21, 2024

Similar to spacetelescope/romancal#1467 and spacetelescope/jwst#8869

Although it looks like only jwst is required there is some CI infrastructure in place for romancal so keeping that context as well. The second argument for the jwst curl command is null which matches what is currently on jwst. It has since diverged from what's on crds (which uses latest) but I don't think that's an issue.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.25%. Comparing base (eb9d316) to head (20511c1).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
- Coverage   87.28%   87.25%   -0.03%     
==========================================
  Files          22       21       -1     
  Lines        3821     3813       -8     
==========================================
- Hits         3335     3327       -8     
  Misses        486      486              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review October 21, 2024 17:06
@braingram braingram requested a review from a team as a code owner October 21, 2024 17:06
@nden nden merged commit 57478e0 into spacetelescope:master Oct 21, 2024
21 of 23 checks passed
@nden nden added this to the 0.22 milestone Oct 21, 2024
@braingram braingram deleted the crds_contexts branch October 21, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants