From 17d28d06420c45e9f5defc06b33332e3c15d8ff9 Mon Sep 17 00:00:00 2001
From: Kyle Conroy <kyleconroy@gmail.com>
Date: Thu, 21 Sep 2023 08:20:04 -0400
Subject: [PATCH] optionally disable moment map server-side saving

---
 .../configs/cubeviz/plugins/moment_maps/moment_maps.py   | 9 +++++++++
 .../configs/cubeviz/plugins/moment_maps/moment_maps.vue  | 6 +++---
 .../configs/cubeviz/plugins/tests/test_cubeviz_helper.py | 5 ++++-
 3 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py b/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py
index 0aadf4797e..70211755ac 100644
--- a/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py
+++ b/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.py
@@ -50,6 +50,11 @@ class MomentMap(PluginTemplateMixin, DatasetSelectMixin, SpectralSubsetSelectMix
     moment_available = Bool(False).tag(sync=True)
     overwrite_warn = Bool(False).tag(sync=True)
 
+    # export_enabled controls whether saving the moment map to a file is enabled via the UI.  This
+    # is a temporary measure to allow server-installations to disable saving server-side until
+    # saving client-side is supported
+    export_enabled = Bool(True).tag(sync=True)
+
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
 
@@ -138,6 +143,10 @@ def vue_overwrite_fits(self, *args):
     def _write_moment_to_fits(self, overwrite=False, *args):
         if self.moment is None or not self.filename:  # pragma: no cover
             return
+        if not self.export_enabled:
+            # this should never be triggered since this is intended for UI-disabling and the
+            # UI section is hidden, but would prevent any JS-hacking
+            raise ValueError("_write_moment_to_fits is currently disabled")
 
         # Make sure file does not end up in weird places in standalone mode.
         path = os.path.dirname(self.filename)
diff --git a/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue b/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
index c259128607..368842c4ee 100644
--- a/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
+++ b/jdaviz/configs/cubeviz/plugins/moment_maps/moment_maps.vue
@@ -49,11 +49,11 @@
       @click:action="calculate_moment"
     ></plugin-add-results>
     
-    <j-plugin-section-header>Results</j-plugin-section-header>
+    <j-plugin-section-header v-if="export_enabled">Results</j-plugin-section-header>
 
     <div style="display: grid; position: relative"> <!-- overlay container -->
       <div style="grid-area: 1/1">
-        <div v-if="moment_available">
+        <div v-if="moment_available && export_enabled">
           <v-row>
               <v-text-field
               v-model="filename"
@@ -77,7 +77,7 @@
       <v-overlay
         absolute
         opacity=1.0
-        :value="overwrite_warn"
+        :value="overwrite_warn && export_enabled"
         :zIndex=3
         style="grid-area: 1/1; 
                margin-left: -24px;
diff --git a/jdaviz/configs/cubeviz/plugins/tests/test_cubeviz_helper.py b/jdaviz/configs/cubeviz/plugins/tests/test_cubeviz_helper.py
index f24c9e9fd1..1700151aad 100644
--- a/jdaviz/configs/cubeviz/plugins/tests/test_cubeviz_helper.py
+++ b/jdaviz/configs/cubeviz/plugins/tests/test_cubeviz_helper.py
@@ -73,7 +73,7 @@ def test_valid_function(cubeviz_helper, spectrum1d_cube):
     assert cubeviz_helper.specviz.get_data(data_label="test[FLUX]").flux.ndim == 1
 
 
-def test_remote_server_disable_movie():
+def test_remote_server_disable_save_serverside():
     config = get_configuration('cubeviz')
     config['settings']['server_is_remote'] = True
 
@@ -82,6 +82,9 @@ def test_remote_server_disable_movie():
     ep = cubeviz_helper.plugins['Export Plot']
     assert ep._obj.movie_enabled is False
 
+    mm = cubeviz_helper.plugins['Moment Map']
+    assert mm._obj.export_enabled is False
+
 
 def test_get_data_spatial_and_spectral(cubeviz_helper, spectrum1d_cube_larger):
     data_label = "test"