Skip to content

Commit

Permalink
[SCSB-145] require Python 3.10 (#2757)
Browse files Browse the repository at this point in the history
* require Python 3.10

prune unnecessary changes

update tests with Python version

apply suggestions from review from pllim

change more references to Python 3.9

* MNT: Drop Python 3.9 (update from pllim)

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
  • Loading branch information
zacharyburnett and pllim authored Apr 22, 2024
1 parent 69edcd4 commit 3c3e174
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 14 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ jobs:
toxposargs: --remote-data
allow_failure: false

- name: OS X - Python 3.9
- name: OS X - Python 3.12
os: macos-latest
python: 3.9
toxenv: py39-test
python: '3.12'
toxenv: py312-test
allow_failure: false

- name: Windows - Python 3.10
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/predeps_workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ jobs:

- name: RC testing on OSX
os: macos-latest
python: 3.9
toxenv: py39-test-predeps
python: '3.10'
toxenv: py310-test-predeps

- name: RC testing on Windows
os: windows-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- uses: actions/setup-python@v5
with:
python-version: 3.9
python-version: '3.10'

- name: Install python-build and twine
run: python -m pip install build "twine>=3.3"
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ Specviz2d
Other Changes and Additions
---------------------------

- Bump required Python version to 3.10. [#2757]

- Line menu in Redshift from Centroid section of Line Analysis now shows values in current units. [#2816]

3.9.2 (unreleased)
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ version conflicts with other packages you may have installed, for example:

.. code-block:: bash
conda create -n jdaviz-env python=3.9
conda create -n jdaviz-env python=3.12
conda activate jdaviz-env
Installing the released version can be done using pip:
Expand Down
2 changes: 1 addition & 1 deletion docs/dev/release.rst
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ You can create a clean checkout as follows (requires

.. code-block:: bash
conda create -n testenv python=3.9
conda create -n testenv python=3.12
conda activate testenv
pip install pytest pytest-astropy pytest-tornasync dist/*.whl
cd ..
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ contextual information like on-sky views of the spectrograph slit.

.. warning::

As of ``jdaviz`` version 3.5, python 3.8 is no longer supported. Please use python 3.9 or
As of ``jdaviz`` version 3.10, please use Python 3.10 or
greater to get the latest bug fixes and feature additions for ``jdaviz``.

.. note::
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Common Issues
If you encounter problems while following these installation instructions,
please consult :ref:`known installation issues <known_issues_installation>`.

Note that ``jdaviz`` requires Python 3.9 or newer. If your ``pip`` corresponds to an older version of
Note that ``jdaviz`` requires Python 3.10 or newer. If your ``pip`` corresponds to an older version of
Python, it will raise an error that it cannot find a valid package.

Users occasionally encounter problems running the pure ``pip`` install above. For those
Expand Down
2 changes: 1 addition & 1 deletion docs/known_bugs.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ compatible version:

.. code-block:: bash
conda create -n jdaviz python=3.8
conda create -n jdaviz python=3.12
conda activate jdaviz
pip install vispy>=0.6.5
pip install jdaviz --no-cache-dir
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[project]
name = "jdaviz"
description = "Astronomical data analysis development leveraging the Jupyter platform"
requires-python = ">=3.9"
requires-python = ">=3.10"
authors = [
{ name = "JDADF Developers", email = "help@stsci.edu" },
]
Expand Down Expand Up @@ -38,7 +38,6 @@ dependencies = [
"sidecar>=0.5.2",
"ipypopout>=0.0.11",
"astroquery",
"y_py<0.5.5;python_version=='3.9'",
]
dynamic = [
"version",
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
py{38,39,310,311,312}-test{,-alldeps,-devdeps,-predeps}{-romandeps}{,-cov}
py{310,311,312}-test{,-alldeps,-devdeps,-predeps}{-romandeps}{,-cov}
linkcheck
codestyle
pep517
Expand Down

0 comments on commit 3c3e174

Please sign in to comment.