Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Remove blanket ignore for test warnings and fix failures #2461

Open
Jdaviz-Triage-Bot opened this issue Sep 14, 2023 · 2 comments
Open
Labels

Comments

@Jdaviz-Triage-Bot
Copy link

Jdaviz-Triage-Bot commented Sep 14, 2023

Reporter: pllim

jdaviz/pyproject.toml

Lines 140 to 149 in 639d22e

"ignore::DeprecationWarning:glue",
"ignore::DeprecationWarning:bqplot",
"ignore::DeprecationWarning:bqplot_image_gl",
"ignore::DeprecationWarning:bqscales",
"ignore::DeprecationWarning:traittypes",
"ignore::DeprecationWarning:voila",
"ignore::DeprecationWarning:asteval",
"ignore::DeprecationWarning:dask",
"ignore::FutureWarning:asteval",
"ignore:::specutils.spectra.spectrum1d",

The blanket ignores can accidentally ignore things we care about (e.g., #2460). We should remove these and handle any remaining warnings individually as appropriate:

a. fix the problem,
b. ignore it locally only for the affected line of code in tests, or
c. a more specific blanket ignore

If this turns out to be too much work, might have to split into smaller tickets focusing only on a subset of these.

🐱


DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter.

@pllim pllim added the testing label Sep 14, 2023
@stscijgbot-jwql
Copy link

This issue is tracked on JIRA as JDAT-3810.

@stscijgbot-jwql
Copy link

Comment by Kyle Conroy on JIRA:

NOTICE: A corresponding GitHub issue was automatically created: #2461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants