Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Imviz not sizing properly on Notebook 7.0.4 #2468

Closed
duytnguyendtn opened this issue Sep 20, 2023 · 4 comments
Closed

[BUG] Imviz not sizing properly on Notebook 7.0.4 #2468

duytnguyendtn opened this issue Sep 20, 2023 · 4 comments
Labels
bug Something isn't working imviz needs-triage Issue opened via template and needs triaging

Comments

@duytnguyendtn
Copy link
Collaborator

duytnguyendtn commented Sep 20, 2023

Jdaviz component

Imviz

Description

Ran into this issue on Imviz with the new Jupyter Notebook release (pulled automatically via pip install jdaviz). Cell size does not respect the height of the viewer and only shows the full height once the plugin bar is opened:

Untitled.-.Brave.2023-09-20.11-37-57.mp4

Rolling back to notebook==6.5.6 fixed the issue

Basic information:
Windows (of course 😉)
Python 3.10.10
Jdaviz 3.6.2
Notebook 7.0.4

How to Reproduce

  1. Install release jdaviz with pip install jdaviz
  2. Create a new notebook on 7.0.4
  3. Import Imviz and show()

Expected behavior

Cell size expands to show viewer

Browser

Brave Version 1.58.127 Chromium: 117.0.5938.88 (Official Build) (64-bit)

Jupyter

Selected Jupyter core packages...
IPython : 8.15.0
ipykernel : 6.25.2
ipywidgets : 8.1.1
jupyter_client : 7.4.9
jupyter_core : 5.3.1
jupyter_server : 2.7.3
jupyterlab : 4.0.6
nbclient : 0.7.4
nbconvert : 7.8.0
nbformat : 5.9.2
notebook : 7.0.4
qtconsole : 5.4.4
traitlets : 5.10.0

Software versions

Python 3.10.10 (tags/v3.10.10:aad5f6a, Feb 7 2023, 17:20:36) [MSC v.1929 64 bit (AMD64)] on win32

freeze.txt

pip freeze

anyio==4.0.0
argon2-cffi==23.1.0
argon2-cffi-bindings==21.2.0
arrow==1.2.3
asdf==2.15.1
asdf-astropy==0.4.0
asdf-coordinates-schemas==0.2.0
asdf-standard==1.0.3
asdf-transform-schemas==0.3.0
asdf-unit-schemas==0.1.0
asdf-wcs-schemas==0.2.0
asteval==0.9.31
astropy==5.3.3
astroquery==0.4.6
asttokens==2.4.0
async-lru==2.0.4
attrs==23.1.0
Babel==2.12.1
backcall==0.2.0
beautifulsoup4==4.12.2
bleach==6.0.0
bqplot==0.12.40
bqplot-gl==0.0.0
bqplot-image-gl==1.4.11
casa-formats-io==0.2.1
certifi==2023.7.22
cffi==1.15.1
charset-normalizer==3.2.0
click==8.1.7
cloudpickle==2.2.1
colorama==0.4.6
comm==0.1.4
contourpy==1.1.1
cycler==0.11.0
dask==2023.9.2
debugpy==1.8.0
decorator==5.1.1
defusedxml==0.7.1
dill==0.3.7
echo==0.8.0
entrypoints==0.4
et-xmlfile==1.1.0
exceptiongroup==1.1.3
executing==1.2.0
fast-histogram==0.11
fastjsonschema==2.18.0
fonttools==4.42.1
fqdn==1.5.1
freetype-py==2.4.0
fsspec==2023.9.1
glue-astronomy==0.10.0
glue-core==1.13.1
glue-jupyter==0.18.0
glue-qt==0.2.0
glue-vispy-viewers==1.1.0
gwcs==0.19.0
h5py==3.9.0
hsluv==5.0.4
html5lib==1.1
idna==3.4
imageio==2.31.3
importlib-metadata==6.8.0
ipydatawidgets==4.3.5
ipygoldenlayout==0.4.0
ipykernel==6.25.2
ipympl==0.9.3
ipypopout==1.0.0
ipysplitpanes==0.2.0
ipython==8.15.0
ipython-genutils==0.2.0
ipyvolume==0.6.3
ipyvue==1.10.1
ipyvuetify==1.8.10
ipywebrtc==0.6.0
ipywidgets==8.1.1
isoduration==20.11.0
jaraco.classes==3.3.0
jdaviz==3.6.2
jedi==0.19.0
Jinja2==3.1.2
jmespath==1.0.1
joblib==1.3.2
json5==0.9.14
jsonpointer==2.4
jsonschema==4.19.1
jsonschema-specifications==2023.7.1
jupyter-events==0.7.0
jupyter-lsp==2.2.0
jupyter_client==7.4.9
jupyter_core==5.3.1
jupyter_server==2.7.3
jupyter_server_terminals==0.4.4
jupyterlab==4.0.6
jupyterlab-pygments==0.2.2
jupyterlab-widgets==3.0.9
jupyterlab_server==2.25.0
keyring==24.2.0
kiwisolver==1.4.5
lazy_loader==0.3
locket==1.0.0
MarkupSafe==2.1.3
matplotlib==3.8.0
matplotlib-inline==0.1.6
mistune==3.0.1
more-itertools==10.1.0
mpl-scatter-density==0.7
nbclassic==1.0.0
nbclient==0.7.4
nbconvert==7.8.0
nbformat==5.9.2
ndcube==2.1.3
nest-asyncio==1.5.8
networkx==3.1
notebook==7.0.4
notebook_shim==0.2.3
numpy==1.26.0
openpyxl==3.1.2
overrides==7.4.0
packaging==23.1
pandas==2.1.0
pandocfilters==1.5.0
parso==0.8.3
partd==1.4.0
photutils==1.9.0
pickleshare==0.7.5
Pillow==10.0.1
platformdirs==3.10.0
prometheus-client==0.17.1
prompt-toolkit==3.0.39
psutil==5.9.5
pure-eval==0.2.2
pvextractor==0.3
pycparser==2.21
pyerfa==2.0.0.3
Pygments==2.16.1
PyOpenGL==3.1.7
pyparsing==3.1.1
python-dateutil==2.8.2
python-json-logger==2.0.7
pythreejs==2.4.2
pytz==2023.3.post1
pyvo==1.4.2
PyWavelets==1.4.1
pywin32==306
pywin32-ctypes==0.2.2
pywinpty==2.0.11
PyYAML==6.0.1
pyzmq==24.0.1
qtconsole==5.4.4
QtPy==2.4.0
radio-beam==0.3.4
referencing==0.30.2
regions==0.7
requests==2.31.0
rfc3339-validator==0.1.4
rfc3986-validator==0.1.1
rpds-py==0.10.3
scikit-image==0.21.0
scipy==1.11.2
semantic-version==2.10.0
Send2Trash==1.8.2
sidecar==0.7.0
six==1.16.0
sniffio==1.3.0
soupsieve==2.5
specreduce==1.3.0
spectral-cube==0.6.2
specutils==1.11.0
stack-data==0.6.2
stdatamodels==1.8.1
synphot==1.2.1
terminado==0.17.1
tifffile==2023.9.18
tinycss2==1.2.1
tomli==2.0.1
toolz==0.12.0
tornado==6.3.3
traitlets==5.10.0
traittypes==0.2.1
typing_extensions==4.8.0
tzdata==2023.3
uri-template==1.3.0
urllib3==2.0.5
vispy==0.14.0
voila==0.4.3
wcwidth==0.2.6
webcolors==1.13
webencodings==0.5.1
websocket-client==1.6.3
websockets==11.0.3
widgetsnbextension==4.0.9
xlrd==2.0.1
zipp==3.17.0

@duytnguyendtn duytnguyendtn added bug Something isn't working needs-triage Issue opened via template and needs triaging labels Sep 20, 2023
@pllim pllim added the imviz label Sep 20, 2023
@pllim
Copy link
Contributor

pllim commented Sep 20, 2023

I think this has been fixed in #2420 but unreleased. Can you please try with main?

@duytnguyendtn
Copy link
Collaborator Author

@pllim Yup that did it, thanks! Any word on a bugfix for jdaviz 3.6?

@pllim
Copy link
Contributor

pllim commented Sep 20, 2023

@cshanahan1 is planning to do a 3.7 release this week. :)

@duytnguyendtn
Copy link
Collaborator Author

Perfect, thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz needs-triage Issue opened via template and needs triaging
Projects
None yet
Development

No branches or pull requests

2 participants