Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support deleting all viewers without crashing app #2745

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Mar 8, 2024

Description

This pull request "fixes" the viewer select to allow it to become empty if all viewers are removed from the app. It also hides elements in the plot options plugin that are not applicable if no viewers are selected.

None of the configs in jdaviz currently allow deleting all viewers, so this should not affect users in any way.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the no-changelog-entry-needed changelog bot directive label Mar 8, 2024
@kecnry kecnry added this to the 3.9 milestone Mar 8, 2024
@github-actions github-actions bot added the plugin Label for plugins common to multiple configurations label Mar 8, 2024
@kecnry kecnry mentioned this pull request Mar 8, 2024
8 tasks
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as Imviz keeps the default viewer always, this is fine. Thanks!

@kecnry
Copy link
Member Author

kecnry commented Mar 8, 2024

As long as Imviz keeps the default viewer always, this is fine.

I see no reason we can't allow that in the future, but there are currently a bunch of assumptions that will need to be removed, so this does not aim to support that (yet).

@pllim pllim merged commit 324c96f into spacetelescope:main Mar 8, 2024
19 checks passed
@kecnry kecnry deleted the empty-viewer-select branch March 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants