-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change moment input field text to 'rest wavelength' #2748
Conversation
Do you want to backport this? |
I don't think it's that urgent/important. Plus I don't think we'll do a 3.8.3 release before 3.9. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 88.92% 88.63% -0.30%
==========================================
Files 108 108
Lines 16003 16210 +207
==========================================
+ Hits 14230 14367 +137
- Misses 1773 1843 +70 ☔ View full report in Codecov by Sentry. |
Hang on - #2697 had just done the exact opposite 🤔 |
I think we DO NOT want "rest" and instead want either "central" or "observed", right? Perhaps a duplicate ticket was created forgetting that we had already done this but it just wasn't in the released version yet? |
Hmmm, looks like that's possible. I see you reached out to Patrick, we'll see what he says. |
Also I totally misread the "from" and "to" in the Jira ticket, I'll open a PR to correct this after Patrick clarifies. Looks like he opened a Jira issue not realizing it had already been changed, which was confusing. |
Should I revert this PR? |
Sure, if it's quick you can revert it before I open another PR with the correct change. |
OK, please see #2753 . Sorry for merging too quickly! |
Clarify this text slightly.