Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change moment input field text to 'rest wavelength' #2748

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Mar 12, 2024

Clarify this text slightly.

@rosteen rosteen added UI/UX😍 trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations labels Mar 12, 2024
@rosteen rosteen added this to the 3.9 milestone Mar 12, 2024
@pllim
Copy link
Contributor

pllim commented Mar 12, 2024

Do you want to backport this?

@rosteen
Copy link
Collaborator Author

rosteen commented Mar 12, 2024

Do you want to backport this?

I don't think it's that urgent/important. Plus I don't think we'll do a 3.8.3 release before 3.9.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (f9c348e) to head (adda177).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2748      +/-   ##
==========================================
- Coverage   88.92%   88.63%   -0.30%     
==========================================
  Files         108      108              
  Lines       16003    16210     +207     
==========================================
+ Hits        14230    14367     +137     
- Misses       1773     1843      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit 4907826 into spacetelescope:main Mar 12, 2024
25 of 26 checks passed
@kecnry
Copy link
Member

kecnry commented Mar 13, 2024

Hang on - #2697 had just done the exact opposite 🤔

@kecnry
Copy link
Member

kecnry commented Mar 13, 2024

I think we DO NOT want "rest" and instead want either "central" or "observed", right? Perhaps a duplicate ticket was created forgetting that we had already done this but it just wasn't in the released version yet?

@rosteen
Copy link
Collaborator Author

rosteen commented Mar 13, 2024

I think we DO NOT want "rest" and instead want either "central" or "observed", right? Perhaps a duplicate ticket was created forgetting that we had already done this but it just wasn't in the released version yet?

Hmmm, looks like that's possible. I see you reached out to Patrick, we'll see what he says.

@rosteen
Copy link
Collaborator Author

rosteen commented Mar 13, 2024

Also I totally misread the "from" and "to" in the Jira ticket, I'll open a PR to correct this after Patrick clarifies. Looks like he opened a Jira issue not realizing it had already been changed, which was confusing.

@pllim
Copy link
Contributor

pllim commented Mar 13, 2024

Should I revert this PR?

@rosteen
Copy link
Collaborator Author

rosteen commented Mar 13, 2024

Should I revert this PR?

Sure, if it's quick you can revert it before I open another PR with the correct change.

@pllim
Copy link
Contributor

pllim commented Mar 13, 2024

OK, please see #2753 . Sorry for merging too quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz no-changelog-entry-needed changelog bot directive plugin Label for plugins common to multiple configurations trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants