[SCSB-145] require Python 3.10 #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
requested review from
rosteen,
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
pllim
reviewed
Mar 14, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
zacharyburnett
commented
Mar 14, 2024
|
Sorry for the extra changes! I used this ticket to test making batch PRs |
pllim
reviewed
Mar 14, 2024
pllim
reviewed
Mar 14, 2024
pllim
reviewed
Mar 14, 2024
pllim
reviewed
Mar 14, 2024
This comment was marked as resolved.
This comment was marked as resolved.
prune unnecessary changes update tests with Python version apply suggestions from review from pllim change more references to Python 3.9
pllim
approved these changes
Apr 18, 2024
|
Merging would need admin override because branch protection rules have changed. After merge, admin needs to update branch protection rule for the OSX job. |
|
CI failure is unrelated (#2811). |
|
cc @larrybradley and @camipacifici since they asked about dropping Python 3.9 earlier. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2757 +/- ##
==========================================
- Coverage 88.88% 88.88% -0.01%
==========================================
Files 111 111
Lines 16983 16978 -5
==========================================
- Hits 15096 15091 -5
Misses 1887 1887 ☔ View full report in Codecov by Sentry. |
|
Thanks, @zacharyburnett ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves SCSB-145
propagate Astropy's deprecation of Python 3.9 to downstream packages
Note
this PR was generated automatically by
batchpr🤖Close #2000
🐱