Random sampling for Plot Options histogram

[pllim]

Description

This pull request is to

• Revert BUG: Always downsample histogram for Imviz in Plot Options #2735
• Use random sampling inspired by Add the ability to specify a random subset size for computing histogram glue-viz/glue#2478

Since we do not use glue-native histogram directly, not sure if we can take advantage of the following upstream PRs directly:

• Add the ability to specify a random subset size for computing histogram glue-viz/glue#2478
• Expose ability to use a random subset of data for computing histograms glue-viz/glue-jupyter#424

TODO

• There must be some subtlety I am missing here because the random sampling is not giving any performance boost on a 8GB image. 😆

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

[astrofrog]

Using this branch with a ~4Gb dataset, the histogram seems pretty fast to me. Can you try and measure the time for the histogram to update using e.g:

%time po.stretch_hist_nbins = 300

just so we can rule out other issues such as the image viewer itself being slow.

[astrofrog]

On further investigation I can reproduce the issue. However it does look like you are using the glue histogram viewer beneath the hood, let me see what we can do.

[pllim]

Good catch on the nan stuff. I am going to close this in favor of yours. Thanks, Tom!