Prevent recursive matched zoom in Imviz #2764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enables the option in the matched zoom within Imviz to disable matched zoom tools in other viewers to avoid unintended recursion. This is consistent with the handling in specviz2d for a similar issue there. We could instead implement some tolerance to break out of the recursion, but I fear that won't be robust and might not behave consistently.
Perhaps #2751 would avoid the need for this, since this was not necessary before the new image rotation work broke roundtripping of the zoom limits.Note that this was not an issue in 3.8.x, so is not milestoned for backporting.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.