Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent recursive matched zoom in Imviz #2764

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Mar 20, 2024

Description

This pull request enables the option in the matched zoom within Imviz to disable matched zoom tools in other viewers to avoid unintended recursion. This is consistent with the handling in specviz2d for a similar issue there. We could instead implement some tolerance to break out of the recursion, but I fear that won't be robust and might not behave consistently.

Perhaps #2751 would avoid the need for this, since this was not necessary before the new image rotation work broke roundtripping of the zoom limits.

Note that this was not an issue in 3.8.x, so is not milestoned for backporting.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.9 milestone Mar 20, 2024
@github-actions github-actions bot added imviz plugin Label for plugins common to multiple configurations labels Mar 20, 2024
@kecnry kecnry force-pushed the prevent-recursive-match-zoom branch from 8af4b25 to 5b7f068 Compare March 20, 2024 17:20
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (5afa49f) to head (5b7f068).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2764      +/-   ##
==========================================
+ Coverage   88.67%   88.72%   +0.05%     
==========================================
  Files         108      108              
  Lines       16266    16288      +22     
==========================================
+ Hits        14424    14452      +28     
+ Misses       1842     1836       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review March 20, 2024 17:55
Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to reproduce the bug in standalone, but I was able to do so in a notebook. Bearing this, the fix is, no more wandering images!

@pllim pllim added the bug Something isn't working label Mar 21, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear why this was set to False back in #2219 but I think this diff makes sense. Thanks!

@pllim pllim merged commit a965933 into spacetelescope:main Mar 21, 2024
24 checks passed
@kecnry kecnry deleted the prevent-recursive-match-zoom branch March 21, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working imviz plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants