Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent recursive matched zoom in Imviz #2764

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Prevent recursive matched zoom in Imviz #2764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ Imviz

- Add "Random" colormap for visualizing image segmentation maps. [#2671]

- Enabling any matched zoom tool in a viewer disables other matched zoom tools in other viewers
to avoid recursion. [#2764]

Mosviz
^^^^^^

Expand Down
2 changes: 1 addition & 1 deletion jdaviz/configs/imviz/plugins/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

class _ImvizMatchedZoomMixin(_MatchedZoomMixin):
match_keys = ('x_min', 'x_max', 'y_min', 'y_max')
disable_matched_zoom_in_other_viewer = False
disable_matched_zoom_in_other_viewer = True

def _is_matched_viewer(self, viewer):
return isinstance(viewer, BqplotImageView)
Expand Down
2 changes: 1 addition & 1 deletion jdaviz/core/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def save_prev_zoom(self):

class _MatchedZoomMixin:
match_axes = ('x', 'y')
disable_matched_zoom_in_other_viewer = False
disable_matched_zoom_in_other_viewer = True

def _is_matched_viewer(self, viewer):
return True
Expand Down