Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert flux cubes to per-square-pixel surface brightness cubes #3156

Merged
merged 77 commits into from
Sep 20, 2024

.

a476aa8
Select commit
Loading
Failed to load commit list.
Merged

convert flux cubes to per-square-pixel surface brightness cubes #3156

.
a476aa8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 20, 2024 in 0s

88.33% (-0.18%) compared to d49e3b5

View this Pull Request on Codecov

88.33% (-0.18%) compared to d49e3b5

Details

Codecov Report

Attention: Patch coverage is 91.40625% with 22 lines in your changes missing coverage. Please review.

Project coverage is 88.33%. Comparing base (d49e3b5) to head (a476aa8).

Files with missing lines Patch % Lines
jdaviz/configs/cubeviz/plugins/parsers.py 79.41% 7 Missing ⚠️
jdaviz/app.py 62.50% 6 Missing ⚠️
jdaviz/configs/default/plugins/viewers.py 89.47% 2 Missing ⚠️
...specviz/plugins/unit_conversion/unit_conversion.py 88.23% 2 Missing ⚠️
jdaviz/core/marks.py 33.33% 2 Missing ⚠️
...igs/default/plugins/model_fitting/model_fitting.py 98.11% 1 Missing ⚠️
...imviz/plugins/aper_phot_simple/aper_phot_simple.py 96.29% 1 Missing ⚠️
jdaviz/core/validunits.py 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   88.50%   88.33%   -0.18%     
==========================================
  Files         124      124              
  Lines       18448    18572     +124     
==========================================
+ Hits        16327    16405      +78     
- Misses       2121     2167      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov