Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/RTD failures #3317

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix CI/RTD failures #3317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb0cd81
Add intersphinx ref
rosteen Nov 22, 2024
6ed0bb4
ignore mpl_scatter_density deprecation warning
kecnry Nov 25, 2024
29c0b31
specify mpl_scatter_density only
kecnry Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jdaviz/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def flux_conversion(values, original_units, target_units, spec=None, eqv=None, s
spec : `~specutils.Spectrum1D`, optional
The Spectrum1D object that will have converted flux or surface brightness units.

eqv : list of `astropy.units.equivalencies`, optional
eqv : list of :ref:`astropy:unit_equivalencies`, optional
A list of Astropy equivalencies necessary for complex unit conversions/translations.

slice : `astropy.units.Quantity`, optional
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ filterwarnings = [
"ignore::DeprecationWarning:glue",
"ignore::DeprecationWarning:asteval",
"ignore:::specutils.spectra.spectrum1d",
# Remove the following line once https://github.com/astrofrog/mpl-scatter-density/issues/46 is addressed
"ignore:pkg_resources is deprecated as an API:DeprecationWarning:mpl_scatter_density",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can have reminder, can use a cross link here:

# Ignore numpy 2.0 warning, see https://github.com/astropy/astropy/pull/15495
# and https://github.com/scipy/scipy/pull/19275
"ignore:.*numpy\\.core.*:DeprecationWarning",
Expand Down