Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cal pipeline regression tests to use in-flight data #7280

Closed
stscijgbot-jp opened this issue Oct 15, 2022 · 6 comments
Closed

Update Cal pipeline regression tests to use in-flight data #7280

stscijgbot-jp opened this issue Oct 15, 2022 · 6 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-2928 was created on JIRA by Howard Bushouse:

In order to get more robust testing of new reference files and algorithms, we need to update as many of the nightly regression tests as we can with in-flight data for each observing mode. A checklist of modes is provided below.

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Oct 15, 2022

Comment by Howard Bushouse on JIRA:

||Mode||Test module||Assignee||Status||
|FGS Imaging|test_fgs_image2.py|David Grumm|Done|
|FGS Guiding|test_fgs_guider.py| |Needs update|
|MIRI Imaging|test_miri_image.py|Howard Bushouse |Done|
|MIRI LRS Slit|test_miri_lrs_slit_spec2.py
test_miri_lrs_slit_spec3.py|Howard Bushouse 
Howard Bushouse |Done
Done|
|MIRI LRS Slitless|test_miri_lrs_slitless.py|Howard Bushouse |Done|
|MIRI MRS|test_miri_cubebuild.py
test_miri_mrs_spec2.py
test_miri_mrs_spec3.py|Howard Bushouse
Howard Bushouse 
Jane Morrison |Done
Done
In progress|
|MIRI Coron|test_miri_coron3.py
test_miri_coron_rateint.py|Howard Bushouse |Done
Needs renaming or include in test_miri_coron3.py|

 
|NIRCam Imaging|test_nircam_image.py
test_nircam_subarray_4amp.py
test_nircam_align_to_gaia.py| |Needs update|
|NIRCam MT Imaging|test_nircam_mtimage.py| |Needs update|
|NIRCam Coron|test_nircam_coron3.py|Howard Bushouse |Done|
|NIRCam WFSS|test_nircam_wfss_spec2.py
test_nircam_wfss_contam.py| |Needs update|
|NIRCam WFS|test_nircam_wfs.py| | |
|NIRCam TS Image|test_nircam_tsimg.py| |Needs update|
|NIRCam TS Grism|test_nircam_tsgrism.py|Kenneth MacDonald |In progress; status?|
|NIRISS Imaging|N/A| | |
|NIRISS SOSS|test_niriss_soss.py|Howard Bushouse |Done|
|NIRISS WFSS|test_niriss_wfss.py|Howard Bushouse |Done|
|NIRISS AMI|test_niriss_ami3.py|Howard Bushouse |Done|
|NIRSpec FS|test_nirspec_fs_spec2.py
test_nirspec_fs_spec3.py|Tyler Pauly |Done|
|NIRSpec FS BrightObj|test_nirspec_brightobj.py|Tyler Pauly |Needs to be re-visited once NRS ref files updated|
|NIRSpec MOS|test_nirspec_mos_spec2.py,
test_nirspec_masterbackground.py|Howard Bushouse 
Howard Bushouse |Done
Done|
|NIRSpec IFU|test_nirspec_ifu_spec2.py
test_nirspec_ifu_spec3.py
test_nirspec_ifu_internal_cal.py|Howard Bushouse
Maria Pena-Guerrero
Maria Pena-Guerrero  |Done
Needs update
Needs update|

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Suitable data files to use to update tests have started to be collected in ███████████████████████████████████████████

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Tyler Pauly on JIRA:

Perhaps revisit the remaining gaps with files suggested by INS teams here: https://outerspace.stsci.edu/display/JWSTPWG/INS+Regression+Testing

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Melanie Clarke on JIRA:

NIRSpec IRS2 data for detector1 checks updated in #8687

@stscijgbot-jp
Copy link
Collaborator Author

stscijgbot-jp commented Oct 7, 2024

Comment by Melanie Clarke on JIRA:

Reviewing the current state of the repository + artifactory, it looks like these are the tests that are still using pre-flight data:

  • FGS
    ** test_fgs_guider
    *** PR: #⁠8923 - merged
  • MIRI
    ** test_miri_dark
    *** PR: #⁠8925 - merged
    ** test_miri_setpointing
    *** PR: #⁠8887 - merged
    ** test_miri_lrs_dedicated_mbkg
    *** PR: #⁠8927 - merged
    ** test_miri_lrs_masterbg_user
    *** PR: #⁠8927 - merged
    ** test_miri_lrs_nod_masterbg
    *** PR: #⁠8927 - merged
    ** test_miri_mrs_tso
    *** PR: #⁠8936 - merged
    ** test_miri_mrs_dedicated_mbkg
    *** PR: #⁠8936 - merged
    ** test_miri_mrs_nod_masterbg
    *** PR: #⁠8936 - merged
  • NIRCam
    ** test_nircam_image (test_image3_closedfile, test_nircam_frame_averaged_darks)
    *** PR: #⁠8871 - merged
    ** test_nircam_mtimage
    *** PR: #⁠8865 - merged
    *** PR for test_nircam_image_moving_target_kwds: #⁠8873 - merged
    ** test_nircam_tsgrism
    *** PR: #⁠8877 - merged
    *** PR for setpointing: #⁠8887 - merged
    ** test_nircam_tsimg
    *** PR: #⁠8877 - merged
    *** PR for setpointing: #⁠8887 - merged
    ** test_nircam_wfs
    *** PR: #⁠8867 - merged
    ** test_nircam_subarray_4amp
    *** PR: #⁠8881 - merged
  • NIRSpec
    ** test_nirspec_wcs
    *** PR: #⁠8875 - merged
    ** test_nirspec_steps_spec2
    *** PR: #⁠8884 - merged
    ** test_nirspec_subarray
    *** PR: #⁠8895 - merged
    ** test_nirspec_masterbackground
    *** PR: #⁠8912 - merged
    ** test_nirspec_exceptions
    *** PR: #⁠8895 - merged
    ** test_nirspec_image2
    *** PR: #⁠8895 - merged
    ** test_nirspec_verify
    *** PR: #⁠8895 - merged
    ** test_nirspec_lamp_ifu_spec2
    *** PR: #⁠8898 - merged
    ** test_nirspec_lamp_fs_spec2
    *** PR: #⁠8898 - merged
    ** test_nirspec_mos_spec2_steps
    *** PR: #⁠8884 - merged
    ** test_nirspec_brightobj
    *** PR: #⁠8922 - merged
    ** test_nirspec_fs_spec2 (test_pathloss_*) 
    *** PR: #⁠8922 - merged

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Melanie Clarke on JIRA:

All regression tests using FITS data should now be using flight data examples. Association data will be updated in JP-3756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant