Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put index.html in correct location when there is no PID subdirectory #17

Open
bhilbert4 opened this issue Feb 18, 2022 · 1 comment
Open

Comments

@bhilbert4
Copy link
Collaborator

from Jo Taylor:

Just tested it for NIRISS commissioning data and it worked great. The only issue I had was when I set skip_propID2outsubdir to True and also made the index.html file. In this case it downloaded all files to outrootdir, but wrote the index.html to outrootdir/PID, with the locations of the jpegs also pointing to the PID subdir, even though they actually existed one directory up in outrootdir. Therefore none of the thumbnails worked.

@bhilbert4
Copy link
Collaborator Author

While investigating this, I found that the index.html file often has duplicate entries, where everything is the same except for the obsID (NOT the useful one, but the one with value e.g. 71673915) and parent_obsid (which has similar values). I wonder if there's some filtering going on using these columns that instead should use the more traditional obsid (e.g. jw01409103001_02101_00001_nrca1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant