Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify webpage_level12_jpgs and webpage_cols4table #42

Open
bhilbert4 opened this issue Apr 5, 2023 · 0 comments
Open

Simplify webpage_level12_jpgs and webpage_cols4table #42

bhilbert4 opened this issue Apr 5, 2023 · 0 comments

Comments

@bhilbert4
Copy link
Collaborator

webpage_level12_jpgs lists the suffixes of the jpg file types for which jpg thumbnails are created.
webpage_cols4table lists the columns that will be written to the index.html file.

At the moment, there is very little checking that these two lists are consistent. #41 adds a small check such that any suffixes in webpage_level12_jpgs but not in webpage_cols4table will not crash the code. But checking for the opposite situation, where the user requests a column in the html file for which they did not ask for jpgs, is much harder to check for. And if there is a jpg suffix in webpage_cols4table that is not in webpage_level12_jpgs, the code crashes.

Easier might be to redefine webpage_cols4table to initially not include any jpg suffixes, and within the code, the entire list of webpage_level12_jpgs will be added to the webpage_cols4table list before creating the html file. In that way, a user would be locked in to seeing all of the jpgs they requested, which doesn't seem like a bad thing. But this way it would be guaranteed that webpage_cols4table would not contain jpg suffixes for which jpgs were not created (unless the user places them in webpage_cols4table to begin with...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant