Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search only returns results for NIRCam #50

Open
jotaylor opened this issue Apr 25, 2023 · 4 comments · Fixed by #51
Open

Search only returns results for NIRCam #50

jotaylor opened this issue Apr 25, 2023 · 4 comments · Fixed by #51

Comments

@jotaylor
Copy link

I have cloned and installed the latest version of the repo, but when I supply a cfg file (attached) that specifies instrument: niriss, the code tries to retrieve nircam data. The output I get is below. I even tried a different cfg file that I know has worked in the past.

> jwst_download.py --config jwst_query.cfg
Loading config file jwst_query.cfg
INSTRUMENT:  nircam
obsmode:  [None]
propID:  01085
obsnums:  [12]
INFO: MAST API token accepted, welcome Jo Taylor [astroquery.mast.auth]
MJD range: 59573.0 60059.976084486516
No obsmode given. Querying for all files for nircam.
WARNING: NoResultsWarning: Query returned no results. [astroquery.mast.discovery_portal]
WARNING!! No observations found!!

################################
NO OBSERVATIONS FOUND! exiting....
################################
############## Nothing selected!!!! exiting...

jwst_query.txt

@bhilbert4
Copy link
Collaborator

Thanks @jotaylor. I think I see what's going on here. Bad logic for managing parameter values between defaults, command line inputs, and config file inputs. It looks like the instrument name is set to niriss from the config file, but is being set back to the default value of nircam later. I'll work on straightening it all out.

@jotaylor
Copy link
Author

This fixed the issue, thanks Bryan!

@jotaylor
Copy link
Author

I noticed it's now printing many lines that look like:
Warning: could not determine obsnum for observation 126845264
Is that a feature or a bug? It doesn't affect anything, I just don't remember seeing that before.

@bhilbert4
Copy link
Collaborator

Interesting. I didn't see that in any of my tests. I'll try with your query above on Monday and see if I can find a way to suppress those messages.

@bhilbert4 bhilbert4 reopened this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants